format.h is bugged

[Silier]

fmt::internal::CharTraits<char>::convert': cannot access private member declared

that basically means one cannot use wstring and pass it to LOGWARNING or similar calls, where conversion is needed.

Issue have been fixed, but we have outdated version: ​https://github.com/fmtlib/fmt/issues/117 File itself is available here: ​https://github.com/fmtlib/fmt/blob/master/include/fmt/format.h

One cannot simply download and replace the file, because there have been done modifications to our version of file, so they need to be done in new version of file too.

Code to reproduce:

LOGWARNING("Passed wrong value %ls", L"wstring");

[adrian]

@Angen could you say how to reproduce this bug?

I put LOGWARNING(L"warning") and LOGWARNING(std::wstring("warning")) in some file and I received completely different compiler errors like followings:

error: no matching function for call to ‘sprintf(const wchar_t [36])’

error: no matching function for call to ‘std::__cxx11::basic_string<wchar_t>::basic_string(const char [11])’

[Silier]

Replying to adrian:

@Angen could you say how to reproduce this bug?

Sorry it took me so long, I have updated ticket with example.