Opened 4 years ago

Closed 4 years ago

#5776 closed defect (fixed)

Context mismatch in CGame::ReallyStartGame()?

Reported by: Bellaz Owned by: Itms
Priority: Should Have Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Itms, wraitii Patch: ​Phab:D2869

Description

In ​CGame::ReallyStartGame(), in the block between ​L328-L333 'global' is rooted with the context of simulation (line 298). However, the rooted Object belongs to g_GUI->GetActiveGUI(), which has another context (g_GUI->GetActiveGUI()->GetScriptInterface()->GetContext()) . Therefore I think that global should be rooted with the context of g_GUI->GetActiveGUI()->GetScriptInterface() and not the one from m_Simulation2->GetScriptInterface() .

Change History (4)

comment:1 by Imarok, 4 years ago

Cc: Itms wraitii added

comment:2 by Itms, 4 years ago

Owner: set to Itms

comment:3 by Itms, 4 years ago

Milestone: Backlog → Alpha 24
Patch: → Phab:D2869

comment:4 by Itms, 4 years ago

Resolution: → fixed
Status: new → closed

In 23815:

Fix rooting mistake in CGame::ReallyStartGame, detected by Bellaz89, fixes #5776.

Differential Revision: ​https://code.wildfiregames.com/D2869
Accepted By: Bellaz89

Note: See TracTickets for help on using tickets.