Opened 2 years ago

Last modified 2 years ago

#5804 new defect

Fail early in premake when using an incorrect library version

Reported by: Itms Owned by:
Priority: Should Have Milestone: Backlog
Component: Build & Packages Keywords:
Cc: Patch:

Description

On Linux, the version of libraries used to build 0ad depends on the package manager and on the user's preferences.

For a few libraries in which the API is not stable, we perform a version check at compile time (currently we do that for SpiderMonkey in source/scriptinterface/ScriptTypes.h, and NVTT after Phab:D2765 is committed).

This is not a good practice, as users may install or build an incorrect version of the lib before getting the error on the version check.

It is particularly cumbersome for maintainers of packages, or for users of any script which builds 0ad in a temporary environment.

We should perform such a check in premake (autoconf usually performs this kind of checks during configure).

Change History (1)

comment:1 by Itms, 2 years ago

In 23974:

Add a NVTT version check at compile-time, fixes #5757, refs #5804.

This will prevent users who have an old NVTT installed on their system from experiencing crashes. Other NVTT issues at runtime should be fixed by clearing the cache.

Differential Revision: https://code.wildfiregames.com/D2765

Note: See TracTickets for help on using tickets.