Opened 4 years ago

Closed 3 years ago

#5842 closed defect (fixed)

Xcursor dependency obsolete

Reported by: Arfrever Frehtes Taifersar Arahesis Owned by: Stan
Priority: Must Have Milestone: Alpha 24
Component: Build & Packages Keywords:
Cc: Arfrever Frehtes Taifersar Arahesis Patch:

Description

Usage of Xcursor was removed in r23364 (git commit b4762a21e8955f65e9dd2db480f7890c035d919f).

Build system still contains: 

$ grep -ir xcursor build
build/jenkins/dockerfiles/gcc6.Dockerfile:    libopenal-dev libpng-dev libsdl2-dev libvorbis-dev libxcursor-dev  \
build/premake/extern_libs5.lua: xcursor = {
build/premake/extern_libs5.lua:                         unix_names = { "Xcursor" },
build/premake/premake5.lua:     table.insert(used_extern_libs, "xcursor")

This results in unnecessary passing of -lXcursor when linking.

Aforementioned references to Xcursor should be removed.

Attachments (1)

0ad-no_Xcursor_dependency.patch​ (1.4 KB ) - added by Arfrever Frehtes Taifersar Arahesis 4 years ago.

Download all attachments as: .zip

Change History (4)

by Arfrever Frehtes Taifersar Arahesis, 4 years ago

Attachment: 0ad-no_Xcursor_dependency.patch​ added

comment:1 by Arfrever Frehtes Taifersar Arahesis, 4 years ago

Successfully tested patch attached.

comment:2 by Stan, 4 years ago

Hey there,

Thanks for the patch! However you need to upload it to Phabricator with full context. See SubmittingPatches. Also do you want credits? If so you need to add yourself to the programming json file.

Thank you in advance.

comment:3 by Stan, 3 years ago

Owner: set to Stan
Resolution: → fixed
Status: new → closed

In 24304:

Remove Xcursor dependency following ​Phab:rP23364
Fixes #5842

Note: See TracTickets for help on using tickets.