Opened 3 years ago

Closed 3 years ago

#5944 closed defect (fixed)

Unit-only attack move not working

Reported by: snelius Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 24
Component: Simulation Keywords: regression
Cc: snelius Patch: Phab:D3436

Description

When given attack move command for the selected group of units (Ctrl + Q + Right Click with unit(s) selected) they should go to the given point attacking enemies on their way. Functionality is not working in a24. Tested on revision 24725.

Change History (5)

comment:1 by Freagarach, 3 years ago

Component: Core engineSimulation
Keywords: formations added; attack move removed
Owner: set to wraitii
Priority: Must HaveRelease Blocker

comment:2 by wraitii, 3 years ago

Confirmed. Caused by my hotkey fixes, because now one can't have both attackmove and attackmoveunit active at the same time, since the latter is more specific. (the thing is that "attackmoveunit" is a modifier to attackmove, not actually considered equivalent to attackmove). You can fix it by setting "attackmoveunit" to another hotkey that doesn't conflict with attackmove. However, since putting "A" would rotate the camera, it's probably not the best call.

I think the solution, which needs a few C++ changes, is to make "attackmove" also register on "Ctrl+A"

comment:3 by wraitii, 3 years ago

Keywords: regression added; formations removed
Summary: Attack move not workingUnit-only attack move not working

comment:4 by Stan, 3 years ago

Patch: Phab:D3436

comment:5 by wraitii, 3 years ago

Resolution: fixed
Status: newclosed

In 24752:

Fix unit-only Attack move.

attackmoveUnit is more specific than attackMove, so since rP24675 won't fire at the same time. However the GUI code expected that, breaking it.

Instead, properly check for either attackmove or attackmoveUnit.

Also fix an issue with rP24675 where hotkeys would be release if switching to a more specific combination of the same hotkey.

Reported by: snelius

Fixes #5944

Differential Revision: https://code.wildfiregames.com/D3436

Note: See TracTickets for help on using tickets.