Opened 3 years ago

Closed 3 years ago

#5966 closed defect (fixed)

Cheering problems

Reported by: wraitii Owned by: Silier
Priority: Release Blocker Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Patch: ​Phab:D3452, ​Phab:D3455

Description

See ​https://code.wildfiregames.com/rP24034#48390

Change History (4)

comment:1 by wraitii, 3 years ago

Patch: → Phab:D3452

comment:2 by Stan, 3 years ago

Patch: Phab:D3452 → Phab:D3452, Phab:D3455

comment:3 by wraitii, 3 years ago

In 24773:

Fix issues with Cheering and PushOrderFront

Make sure that any pending cheering order is deleted when leaving the Cheering state, otherwise other unitAI states can behave weirdly.

This fixes issues with units cheering at incorrect time, then not correctly picking their next target in a fight.

Reported by: snelius

Reviewed By: Angen

Refs #5966

Differential Revision: ​https://code.wildfiregames.com/D3452

comment:4 by Silier, 3 years ago

Owner: set to Silier
Resolution: → fixed
Status: new → closed

In 24774:

Fix cheering issue entering from idle state

Introduced in rP24034.
Units entering cheering from idle state, may not check their surrounding for pottential targets yet, so they will react incorrectly when attacked.
Pointed out by @Freagarach in ​https://code.wildfiregames.com/D1977?id=10404#inline-52415 and turned out to be issue.

Differential revision: D3455
Fixes: #5966
Reviewed by: @wraitii

Note: See TracTickets for help on using tickets.