Assertion failed: "selected >= 0 && selected+1 < (int)m_ItemsYPositions.size()"

[Vas]

Assertion failed: "selected >= 0 && selected+1 < (int)m_ItemsYPositions.size()"
Location: COList.cpp:341 (DrawList)

Call stack:

(0xa8ffe552c56) /usr/bin/pyrogenesis(+0x5f9c56) [0xa8ffe552c56]
(0xa8ffe503862) /usr/bin/pyrogenesis(+0x5aa862) [0xa8ffe503862]
(0xa8ffe504de7) /usr/bin/pyrogenesis(+0x5abde7) [0xa8ffe504de7]
(0xa8ffe505373) /usr/bin/pyrogenesis(+0x5ac373) [0xa8ffe505373]
(0xa8ffe4983fb) /usr/bin/pyrogenesis(+0x53f3fb) [0xa8ffe4983fb]
(0xa8ffe490807) /usr/bin/pyrogenesis(+0x537807) [0xa8ffe490807]
(0xa8ffe47f507) /usr/bin/pyrogenesis(+0x526507) [0xa8ffe47f507]
(0xa8ffe47f529) /usr/bin/pyrogenesis(+0x526529) [0xa8ffe47f529]
(0xa8ffe47f529) /usr/bin/pyrogenesis(+0x526529) [0xa8ffe47f529]
(0xa8ffe47f529) /usr/bin/pyrogenesis(+0x526529) [0xa8ffe47f529]
(0xa8ffe473410) /usr/bin/pyrogenesis(+0x51a410) [0xa8ffe473410]
(0xa8ffe4a70bd) /usr/bin/pyrogenesis(+0x54e0bd) [0xa8ffe4a70bd]
(0xa8ffe1eeea0) /usr/bin/pyrogenesis(+0x295ea0) [0xa8ffe1eeea0]
(0xa8ffdffbe44) /usr/bin/pyrogenesis(+0xa2e44) [0xa8ffdffbe44]
(0xa8ffdfff27d) /usr/bin/pyrogenesis(+0xa627d) [0xa8ffdfff27d]
(0xa8ffdff06cc) /usr/bin/pyrogenesis(+0x976cc) [0xa8ffdff06cc]

errno = 0 (Try again later)
OS error = ?

Steps that I took:

• had one mod downloaded and enabled before
• went to the screen of downloading more mods
• clicked to "download" a new mod (or double-clicked, not sure, but for essentially the same purpose)
• observed the mod being downloaded (probably successfully)
• closed the downloading window, should've gotten back to the screen for enabling mods

0ad version = a23.1 OS = ArchLinux.

[Vas]

UPD: if I click "Continue" in the popup window, the same error just re-appears.

[Vas]

In the reproduction steps, unknown parts:

• don't remember if I've restarted the game already after installing the first mod
• don't remember how many times I clicked to download the new mod (if relevant)
• don't remember if I re-visited some screens back and forth before finally going to the download section, downloading the new mod and going back

[wraitii]

In 24854:

Fix a crash in the mod selector when using the mod downloadder.

When closing the mod downloader, the list of enabled mod is reset, which can lead to an out-of-index assertion failing in the engine if an enabled mod was selected before.

Reported by: Vas

Fixes #6001

Differential Revision: ​https://code.wildfiregames.com/D3537

[Vas]

Nice, thanks for fixing wraitii!