Opened 3 years ago

Last modified 2 years ago

#6093 new defect

Hotkey editor removes unused hotkeys.

Reported by: nani Owned by:
Priority: Must Have Milestone: Backlog
Component: Core engine Keywords: hotkey editor defaults user config remove unused
Cc: Patch: Phab:D3767


When the hotkey editor saves the new hotkeys states, it removes the ones that don't have any mapping assigned, so if you add a hotkey not in default.cfg it will be removed from user.cfg making it dissapear forever.

Case and example:
1) mod adds extra hotkeys
2) user removes mapping to of one of the mods hotkeys
3) save
4) hotkey will no longer show in the hotkey editor ever

Proposal fix: in the hotkey editor have an internal state for each hotkey so it can know if is it in default.cfg (thus can safe delete) or otherwise don't delete it.

Change History (5)

comment:1 by wraitii, 3 years ago

This can be fixed following Phab:D3641, though I don't think that diff fixes that just yet.

comment:2 by wraitii, 3 years ago

Patch: Phab:D3767

comment:3 by wraitii, 3 years ago

Milestone: Alpha 25Alpha 26

comment:4 by Stan, 2 years ago

In r25175:

Show non-default hotkeys that appear in JSON spec files in the hotkey editor.

comment:5 by Freagarach, 2 years ago

Milestone: Alpha 26Backlog
Note: See TracTickets for help on using tickets.