Opened 3 years ago

Last modified 3 years ago

#6133 new enhancement

Clean Identity.js.

Reported by: Freagarach Owned by:
Priority: Should Have Milestone: Backlog
Component: Simulation Keywords:
Cc: Patch:

Description

  • "<element name='Lang' a:help='Unit language for voices.'>" seems like it belongs in the sound component, although one may argue that it is closely related to some other properties stored in Identity.js.
  • "<element name='Rank'>" looks like it should be refactored out using a more extensible promotion system/component.
  • "<element name='Formations' sounds like it should be in UnitAI (or even a seperate FormationMember component).
  • "<element name='RequiredTechnology' a:help='Optional name of a technology which must be researched before the entity can be produced.'>" smells like an extended EntityLimits, [Training|Build]-Restrictions or Cost component of some sorts.

Change History (2)

comment:1 by Freagarach, 3 years ago

(One could also argue for Controllable and Deletable to not belong in Identity.)

comment:2 by Stan, 3 years ago

Disagree for the former one. The language a unit speaks is definitely parts of one's identity :)

Note: See TracTickets for help on using tickets.