Opened 3 years ago

Closed 2 years ago

#6145 closed defect (fixed)

Can't see unselectable civilizations names in Gamesetup.

Reported by: Stan Owned by: Silier
Priority: Must Have Milestone: Alpha 26
Component: UI – Game setup Keywords: regression
Cc: Patch: ​Phab:D4429

Description

Currently one can set civs to not be selectable in gamesetup, e.g a NPC civ, however, if you were to force that civ in the map it would display unknown

​https://i.imgur.com/VHQF5LB.png

In the example above the mod has a NPC civ called Zuna, which is not selectable and not playable and also because of the bug not visible and marked as Unknown.

introduced by: ​Phab:rP23374

Relevant files 

binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerCiv.js
binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/GameSettingControlDropdown.js

Change History (4)

comment:1 by wraitii, 3 years ago

Milestone: Alpha 25 → Alpha 26

comment:2 by Silier, 3 years ago

Priority: Should Have → Must Have

comment:3 by Silier, 2 years ago

Owner: set to Silier
Patch: → Phab:D4429

comment:4 by Silier, 2 years ago

Resolution: → fixed
Status: new → closed

In 26438:

Fix not selectable civilisations not showing if defined by the map

Fix displaying unknow civilisation when civilisation defined by map is not selectable but exists by switching two lists based on if selection is locked or not.

Differential revision: D4429
Fixes: #6145
Reviewed by: @bb

Note: See TracTickets for help on using tickets.