[PetraAI] - Use more enum-like variables instead of special values.

[Freagarach]

In quite some places there are e.g. string literals, or numbers, representing specific cases for a decision. See e.g. baseManager state == "unconstructed" or the subroles of workers. It would be nice if these kind of cases would be set in enum-like properties. E.g. state == BaseManager.UNCONSTRUCTED.

This would lead to better readability of the code (for numbers at least) and less errors due to mistyping.

[Stan]

For the record I like the idea too. With little luck it'll be faster because the strings will be the same memory address. I also like enums.

[Silier]

In 25883:

Remove passability magic numbers from terrain-analysis

Put passability values to prototype variables.
Code looks more readable.

Differential revision: D4236
Refs: #6256
Comments by: @Freagarach, @Stan

[Freagarach]

In [26029]:

[PetraAI] - Use enum-like variables instead of magic values. -- [1]

Improved readability. Easier find-and-replace.

This commit is focused on:

BaseManager
AttackPlan
GarrisonManager

Patch by: @JCWasmx86
Differential revision: ​https://code.wildfiregames.com/D4334
Refs. #6256
Comments by: @Silier, @Stan

[Freagarach]

In 26063:

[PetraAI] - Use enum-like variables instead of magic values. -- [2]

Improved readability. Easier find-and-replace.

This commit focused on:

• Worker
• TransportPlan
• Difficulty

Patch by: @JCWasmx86
Differential revision: ​https://code.wildfiregames.com/D4343
Refs. #6256
Comments by: @nani, @Silier, @Stan