Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#640 closed defect (fixed)

[PATCH] Pasting into the join game "address" field prepends onto the selection

Reported by: dee@earlsoft.co.uk Owned by: Kenny Long
Priority: Nice to Have Milestone: Alpha 6
Component: Non-game systems Keywords: paste, address, network game
Cc: Patch:

Description

When you are joining a network game and you select the current IP to paste in a new one, it prepends it to the current address and highlights the last octet of teh pasted address. When you select the current address and type, it works as expected.

Attachments (1)

CInputFixPasteBug.patch (412 bytes ) - added by Kenny Long 13 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by dee@earlsoft.co.uk, 14 years ago

Summary: Pasting into the join game "address" feild prepends onto the selectionPasting into the join game "address" field prepends onto the selection

comment:2 by Kenny Long, 13 years ago

Owner: set to Kenny Long
Status: newassigned

by Kenny Long, 13 years ago

Attachment: CInputFixPasteBug.patch added

comment:3 by Kenny Long, 13 years ago

Keywords: review added
Summary: Pasting into the join game "address" field prepends onto the selection[PATCH] Pasting into the join game "address" field prepends onto the selection

To clarify, the bug was that when you had text selected in a CInput text field and then you paste into the field, it would not delete the current selection and selected text with the text from the keyboard. It would just append the text from the clipboard to the existing text and reset the active selection.

I added a check to see if we had an active selection and if so it deletes the active selection before inserting the text from the keyboard.

comment:4 by Erik Johansson, 13 years ago

Sweet. You're really getting all these small bugs ironed out :) (Maybe you're ready to take on something bigger? Not that it's bad to have these things fixed, just don't want all the little things gone so other new programmers don't have some place to start ;) )

in reply to:  4 comment:5 by Kenny Long, 13 years ago

Replying to feneur:

Sweet. You're really getting all these small bugs ironed out :) (Maybe you're ready to take on something bigger? Not that it's bad to have these things fixed, just don't want all the little things gone so other new programmers don't have some place to start ;) )

Haha, well there is a method to my madness :). I was thinking about working on the multi-player chat stuff next time, so I wanted to get the textbox cleaned up so the chat would be nicer. Also, I ran into both of those textbox bugs in the game. I am about to post the units getting stuck fix, and thats IS a pretty big one ;). And I also finished the delay in movement issue, which was also driving me crazy. Cheers!

comment:6 by Erik Johansson, 13 years ago

Ah, true :) Great to see you working at such pace in any case, just wanted to be sure that the development is as efficient as possible :) But you seem to have a plan and that's good so keep up the good work.

comment:7 by historic_bruno, 13 years ago

Milestone: BacklogAlpha 6

comment:8 by ben, 13 years ago

Resolution: fixed
Status: assignedclosed

(In [9658]) Applies Kenny's patch for CInput pasting behavior (fixes #640) Simplifies some clipboard hotkeys

comment:9 by historic_bruno, 13 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.