Replays are incorrectly marked as multiplayer

[Stan]

Currently, the condition for a replay to be multiplayer is that it should have less than one AI.

gui/replaymenu/replay_menu.js:130:

replay.isMultiplayer = nonAIPlayers > 1;

This is incorrect because:

• One can want to play single-player without AIs.
• One might play multiplayer with AIs.

It would be better to store the information in the metadata when creating the match, just like campaigns.

[phosit]

Replying to stanislas69:

Currently, the condition for a replay to be multiplayer is that it should have less than one AI.

No. The condition is more than one nonAIPlayer. It is still a defect since not all nonAIPlayer are human-player. There is also <unassigned>.

Game with 1 human-player: single-player
Game with 1 human-player and 1 AI-player: single-player
Game with 1 human-player and 1 <unassigned>: multi-player
Game with 1 human-player, 1 AI-player and 1 <unassigned>: multi-player
Game with 2 haman-player and 2 AI-player: multi-player

[Stan]

Feel free to edit the ticket description :)

[Freagarach]

Pushing back.

[berhudar]

I was wondering that why the game does not consider my lobby played games as a multiplayer game replay, looks like this is what is exactly requested here.

[Stan]

Did you play with AIs ? We need the actual replays not screenshots :)