Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#659 closed defect (wontfix)

OS X Makefile input not properly sanitized

Reported by: Mandrappa Kurelek Owned by:
Priority: Nice to Have Milestone: Alpha 3
Component: Core engine Keywords:
Cc: Patch:

Description

If 0ad is expanded into a directory that has spaces in the name ./update-workspaces.sh (make) fails. Here a snipped of the results of ./update-workspaces.sh inside a directory called "coding for fun":

updating Makefile
creating tests/Makefile
can't read ../tests/Makefile.in: No such file or directory
creating ./config.status
creating config/autoconf.mk
creating js-config.h
js-config.h is unchanged
config/autoconf.mk is unchanged
invoking make to create js-config script
Makefile:630: warning: overriding commands for target `/Users/XYZ/coding'
../config/rules.mk:2082: warning: ignoring old commands for target `/Users/XYZ/coding'
Makefile:630: warning: overriding commands for target `for'
../config/rules.mk:2082: warning: ignoring old commands for target `for'
Makefile:637: warning: overriding commands for target `/Users/XYZ/coding'
Makefile:630: warning: ignoring old commands for target `/Users/XYZ/coding'
Makefile:637: warning: overriding commands for target `for'
Makefile:630: warning: ignoring old commands for target `for'
rm -f js-config.tmp

Of course a trivial workaround is to rename the directory.

Change History (2)

comment:1 by Philip Taylor, 13 years ago

Resolution: wontfix
Status: newclosed

This looks like it's in the SpiderMonkey library, so the bug should get fixed there. We updated to a newer version a couple of weeks ago, but I don't know if that fixes it. If it's still broken, the best approach is to reproduce the problem with the standalone SpiderMonkey build instructions and then file a bug so their developers can fix it.

comment:2 by Kieran P, 13 years ago

Milestone: BacklogAlpha 3
Note: See TracTickets for help on using tickets.