Mouse pointer incorrect when units are selected that can't be garrisoned in own or allied building

[Andy Alt]

If you have units selected that can't be garrisoned in a building, then hold down ctrl and hover the mouse over an allied building (or your own), the mouse pointer becomes a sword.

Examples: if infantry is selected and the pointer is over an elephant cage

if elephants are selected, and the pointer is over a barracks.

---

EDIT

The ticket was originally closed as a wontfix, but after further testing, the red color of the new action-attack-move cursor does make it look just something is wrong. The old cursor was more gray, and the problem was perhaps never reported for that reason.

Image with women trying to put them on a wall with the old & new cursor.

possible solution

• see the code snippet in comment:8

[Stan]

Sounds like A27 Material.

[Freagarach]

The sword is (probably) due to the action being attack-move.

[Andy Alt]

This is a bug. Please review again.

[Andy Alt]

Shows attack/move cursor when a unit can't be garrisoned in own or allied building

[Langbart]

Difference A25 vs latest dev¹ for Siege

• cursor color/ design changes [26448]
• behavior of the ctrl key press was changed
  • unknown changeset

A25 Siege

Latest dev¹ Siege

---

Difference A25 vs latest dev¹ for Soldier

• cursor color/ design changes [26448]
• Switch default behavior from capture to attack. [27399]

A25 Soldier

Latest dev¹ Soldier

---

Footnote

¹ latest dev = [27433]

---

Decision required

1. close the ticket as wontfix
2. change the cursor when pressing ctrl for siege units

[Andy Alt]

I realized it happens not only with siege but other units as well. I've tried to update the title and description to be more accurate.

And thanks for all your detective work and pics, Langbart. :)

[Freagarach]

I vote for option 1, if that wasn't clear yet. Or convince @wowgetoffyourcellphone that a different cursor is needed.

[Langbart]

Replying to Langbart:

1. close the ticket as wontfix
2. change the cursor when pressing ctrl for siege units

Replying to Freagarach:

I vote for option 1

Ticket will be closed as wontfix.

Below are some Options that I considered to meet the ticket's request and my opinion for each.

---

Option A: Add an additional check

If another check is added the issue described in the ticket resolves. The default cursor will be displayed, instead of the attack-move cursor. Ctrl + right-clicking would be the same as just right-clicking. The entity simply walks towards the building.

• opinion: If you attempt to use Attack Move during combat, the cursor could change while accidentally hovering over one of your own units.

binaries/data/mods/public/gui/session/unit_actions.js

@@ -128 +128 @@
         {
             if (!entState.unitAI)
                 return false;
+            if (targetState && playerCheck(entState, targetState, ["Player", "Ally"]))
+                return false;
             return { "possible": true };
         },
         "hotkeyActionCheck": function(target, selection)

---

Option B: Display a different cursor

The ones listed below are included in the base game.

• opinion: None of the cursors currently match the use case, and if you create one, it would be confusing to have two cursors for the same thing.

name	icon
default-arrow.png
action-attack-move.png
action-attack.png
action-blank.png
action-build.png
action-cancel-setup-trade-route.png
action-capture.png
action-collect-treasure.png
action-flare.png
action-garrison-disabled.png
action-garrison.png
action-gather-fish.png
action-gather-fruit.png
action-gather-grain.png
action-gather-meat.png
action-gather-milk.png
action-gather-ore.png
action-gather-rice.png
action-gather-rock.png
action-gather-ruins.png
action-gather-tree.png
action-guard-disabled.png
action-guard.png
action-heal-disabled.png
action-heal.png
action-herd.png
action-occupy-turret-disabled.png
action-occupy-turret.png
action-patrol.png
action-remove-guard.png
action-repair-disabled.png
action-repair.png
action-return-food.png
action-return-metal.png
action-return-stone.png
action-return-wood.png
action-setup-trade-route-disabled.png
action-setup-trade-route.png
action-unload.png
action-unset-rally.png
arrow-default-down.png
cursor-flare.png
cursor-help.png
cursor-no.png
cursor-rally.png
cursor-wait.png

---

Option C: Change

Change back to the old cursor or change the existing one.

• opinion: Besides the new default cursor, all other cursors look great, I would not change it.

name	icon	revision
action-attack-move.png		[26447]
action-attack-move.png		[26448]

[Langbart]

Update description with reason for reopening.

[Stan]

Push back