In some cases, 0ad falsely detects mod incompatibility

[Andy Alt]

If the name field in mod.json is "foo-bar" but the mod directory is "foo_bar" or "foo-bar-1.0", then someone attempting to join from the lobby receives an incompatibility message and cannot join.

Some things that are likely to cause this:

• If the repo is named "foo_bar" but the name field is "foo-bar"
• When the repo name is "foo-bar" and the mod name is "foo-bar" (correct), and someone downloads the zip from the repo home page, which is a snapshot of the repo root, when they unzip the archive, the parent directory would be something like "foo-bar-main" (the branch name appended).

The workaround to prevent the incompatibility message is to make sure your mod name doesn't use underscores and the mod directory is exactly the same as what's in the name field in mod.json.

The modding guide on the wiki should be reviewed; it might be important to make this more clear.

For a more robust fix, I suggest that 0ad should only do comparisons with the mod.json file between host and client, not its parent directory.

Related tickets: ​https://github.com/0ad-matters/community-maps-2/issues/52

[Andy Alt]

Shows incompatibility message