Correct binaries/system/test during rpm build

[pcpa]

Attached patch is required to avoid a build error.

Basically use same approach of other tests that are avoided when there are missing components.

[pcpa]

0ad-check.patch

[Vladislav Belov]

Refs: #6630

[Stan]

Excerpt from an e-mail sent to a maintainer

Hey there,


That's because some of the tests actually expect the public mod to be there. They are more of integration tests.
You can safely ignore them or run them with 0ad-data.

See the discussion here https://irclogs.wildfiregames.com/%230ad-dev/2022-09-20-QuakeNet-%230ad-dev.log as to why an if is a bad idea.


Starting 18:13 

A bit more today: ​https://irclogs.wildfiregames.com/%230ad-dev/2022-10-02-QuakeNet-%230ad-dev.log

[pcpa]

I tested a different approach, that could require 0ad-data to be built first on an update or just be used as a build dependency. Unfortunately, creating symbolic links from an installation to the build tree fails early:

Function call failed: return value was -110300 (Insufficient access rights to open file)
Location: file_system.cpp:157 (CreateDirectories)

It would be an option if it could use the data directory readonly, and use a separate tree for any write operation.

[pcpa@fedora 0ad-0.0.26-alpha]$ ls -l binaries/data/
total 20
lrwxrwxrwx. 1 pcpa pcpa 21 out  3 14:48 config -> /usr/share/0ad/config
lrwxrwxrwx. 1 pcpa pcpa 19 out  3 14:48 l10n -> /usr/share/0ad/l10n
lrwxrwxrwx. 1 pcpa pcpa 19 out  3 14:48 mods -> /usr/share/0ad/mods
lrwxrwxrwx. 1 pcpa pcpa 20 out  3 14:48 tests -> /usr/share/0ad/tests
lrwxrwxrwx. 1 pcpa pcpa 20 out  3 14:48 tools -> /usr/share/0ad/tools

Or make a documented approach. I tested a simple approach removing the binaries/data tree and creating symbolic links from the installed data at /usr/share/0ad.