Changes between Initial Version and Version 4 of Ticket #6701


Ignore:
Timestamp:
Feb 13, 2023, 1:22:05 PM (15 months ago)
Author:
Stan
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6701

    • Property Milestone Alpha 27 → Alpha 28

  • Ticket #6701 – Description

    initial v4  
    22
    33A couple issues make the scripts not work on Linux:
    4 - [[source:ps/trunk/source/tools/dist/build-archives.sh| build-archives.sh]] has a `/bin/sh` shebang, but contains a bashism in defining `LANGS`. So it should be a `/bin/bash` shebang.
     4- ~~[[source:ps/trunk/source/tools/dist/build-archives.sh| build-archives.sh]] has a `/bin/sh` shebang, but contains a bashism in defining `LANGS`. So it should be a `/bin/bash` shebang.
    55- [[source:ps/trunk/source/tools/dist/build-unix-win32.sh| build-unix-win32.sh]] does not work with Linux `tar`: it fails with `tar: '--same-order' cannot be used with '-c'`.
    66
    … …  
    1111
    1212When using NSISBI on Windows, more issues arise:
    13 - ending `ARCHIVE_PATH` with a reverse slash does not work, and not adding the slash makes the installer put mods under `binaries/data/mods/archives`. It would be necessary to change `ARCHIVE_PATH` to not include the final slash on either platform and change [[source:ps/trunk/source/tools/dist/0ad.nsi#L141 | line 141 of 0ad.nsi]] accordingly.
     13- ending `ARCHIVE_PATH` with a backslash does not work, and not adding the slash makes the installer put mods under `binaries/data/mods/archives`. It would be necessary to change `ARCHIVE_PATH` to not include the final slash on either platform and change [[source:ps/trunk/source/tools/dist/0ad.nsi#L141 | line 141 of 0ad.nsi]] accordingly.
    1414- MakeNSISW does not provide a way to change the working directory so it cannot find `FileAssociation.nsh` on [[source:ps/trunk/source/tools/dist/0ad.nsi#L9 | line 9 of 0ad.nsi]]. It would be better to put an explicit `${CHECKOUTPATH}\source\tools\dist\FileAssociation.nsh` there.
    1515