Opened 17 months ago
Last modified 12 months ago
#6701 new defect
Fix the bundling scripts to work on Linux/Windows — at Initial Version
Reported by: | Itms | Owned by: | |
---|---|---|---|
Priority: | If Time Permits | Milestone: | Alpha 27 |
Component: | Build & Packages | Keywords: | |
Cc: | wraitii | Patch: |
Description
Right now the bundling scripts are tailored for use by the CI, which runs them under macOS.
A couple issues make the scripts not work on Linux:
- build-archives.sh has a
/bin/sh
shebang, but contains a bashism in definingLANGS
. So it should be a/bin/bash
shebang. - build-unix-win32.sh does not work with Linux
tar
: it fails withtar: '--same-order' cannot be used with '-c'
.
Extra issue:
- The new way of bundling without a svn export makes
svnversion -n .
spit27473MP
revision strings. Indeed, deleting incomplete translations marks the repo as modified. This is inconsistent with previous releases and current autobuilds which have27473P
revision strings.
Additionally, I would like to know how NSISBI was installed on the CI since I could only find it for Windows. This should be documented in build-unix-win32.sh line 40.
When using NSISBI on Windows, more issues arise:
- ending
ARCHIVE_PATH
with a reverse slash does not work, and not adding the slash makes the installer put mods underbinaries/data/mods/archives
. It would be necessary to changeARCHIVE_PATH
to not include the final slash on either platform and change line 141 of 0ad.nsi accordingly. - MakeNSISW does not provide a way to change the working directory so it cannot find
FileAssociation.nsh
on line 9 of 0ad.nsi. It would be better to put an explicit${CHECKOUTPATH}\source\tools\dist\FileAssociation.nsh
there.
Note:
See TracTickets
for help on using tickets.