Opened 16 months ago

Closed 15 months ago

#6710 closed defect (fixed)

--with-system-premake is broken

Reported by: Stan Owned by: Itms
Priority: Should Have Milestone: Alpha 27
Component: Core engine Keywords:
Cc: Patch:

Description

As reported on ​Phab:D3127 A made a mistake was made when adding a the --with-system-premake option in ​Phab:D2519/ ​Phab:rP23675. It does not go in the correct folder.

Patch by sera:

  • build/workspaces/update-workspaces.sh

    a b fi  
    104104
    105105# Now run premake to create the makefiles
    106106
     107cd ../premake/premake5
     108
    107109premake_command="premake5"
    108110if [ "$with_system_premake5" = "false" ]; then
    109111  # Build bundled premake
    110   cd ../premake/premake5
    111112  PREMAKE_BUILD_DIR=build/gmake2.unix
    112113  # BSD and OS X need different Makefiles
    113114  case "`uname -s`" in

Change History (2)

comment:1 by Itms, 15 months ago

Owner: set to Itms

Hah that's obviously correct! I'll try to test it anyways on a distro that ships premake, and I'll commit it.

comment:2 by Itms, 15 months ago

Resolution: → fixed
Status: new → closed

In 27555:

Fixes --with-system-premake5, fixes #6710, refs rP23675.

Based on fix by sera, tested on Manjaro 22.

Note: See TracTickets for help on using tickets.