Some models trigger black screen issues.

[Stan]

To spot them out you can use

source/graphics/ModelDef.cpp

@@ -65 +65 @@
         for (size_t i = 0; i < numBones; ++i)
             boneMatrix[i] = boneMatrix[i] * inverseBindBoneMatrix[i];
         for (size_t i = 0; i < numverts; ++i)
-            result += SkinPoint(verts[i], boneMatrix.data());
+            result += SkinPoint(verts[i], boneMatrix);
     }
     m_MaxBoundsPerAnimDef[animIndex] = result;
 }
 
 CVector3D CModelDef::SkinPoint(const SModelVertex& vtx,
-                               const CMatrix3D newPoseMatrices[])
+                               const std::vector<CMatrix3D>& newPoseMatrices)
 {
     CVector3D result (0, 0, 0);
 
     for (int i = 0; i < SVertexBlend::SIZE && vtx.m_Blend.m_Bone[i] != 0xff; ++i)
     {
+        ENSURE(vtx.m_Blend.m_Bone[i] < newPoseMatrices.size());
         result += newPoseMatrices[vtx.m_Blend.m_Bone[i]].Transform(vtx.m_Coords) * vtx.m_Blend.m_Weight[i];
     }
 
@@ -450 +451 @@
 
             for (size_t i = 0; i < mdef->m_NumVertices; ++i)
             {
-                mdef->m_pVertices[i].m_Coords = SkinPoint(mdef->m_pVertices[i], &bindPose[0]);
+                mdef->m_pVertices[i].m_Coords = SkinPoint(mdef->m_pVertices[i], bindPose);
                 mdef->m_pVertices[i].m_Norm = SkinNormal(mdef->m_pVertices[i], &bindPose[0]);
             }
         }

source/graphics/ModelDef.h

@@ -204 +204 @@
      * @return new world-space vertex coordinates
      */
     static CVector3D SkinPoint(const SModelVertex& vtx,
-        const CMatrix3D newPoseMatrices[]);
+        const std::vector<CMatrix3D>& newPoseMatrices);
 
     /**
      * Transform the given vertex's normal from the bind pose into the new pose.

Currently affected actor (Maybe more):

• actor|props/structures/celts/merchant_sail_folded.xml
• actor|props/structures/romans/trireme_fore_sail.xml

Might be related to #1012.

Not sure how to fix it in Blender.

Potential temporary solution: Delete the actor.

[Stan]

In artist terms this means:

• Animated models should not have any vertex without weight. See ​https://blender.stackexchange.com/questions/167981/how-to-spot-un-weighted-vertices

[Stan]

In 27515:

Fix two broken models causing black glitches.

• They had vertexes groups without weights.
• Both of them were unused one incorrectly so.
• Also fix the material while at it.

Refs #6714

[Stan]

Keeping this open until we have proper validation.

[Stan]

In 27520:

Fix more issues with animated meshes reported by ​Phab:P293
Reported by: @trompetin17
Refs #6714

[Stan]

Push back