Opened 16 months ago

Last modified 11 months ago

#6722 assigned defect

Invalid mod messages are not properly translated

Reported by: Langbart Owned by: Stan
Priority: Should Have Milestone: Alpha 27
Component: Core engine Keywords:
Cc: Patch: Phab:D4918

Description

to reproduce

  • go into mod.io in-game downloader for A27, try to install 0ad-spirv
  • see image below

nitpick

  • translate the string Invalid signature.
  • source/ps/ModIo.cpp

    a b bool ModIo::ParseSignature(const std::vector<std::string>& minisigs, SigStruct&  
    853853        return true;
    854854    }
    855855
    856     FAIL("Invalid signature.");
     856    FAIL(g_L10n.Translate("Invalid signature."));
    857857#undef CLEANUP
    858858}
  • navigate to source/tools/i18n and run python3 updateTemplates.py
  • the string shows up
  • binaries/data/l10n/engine.pot

    a b msgstr ""  
    240240msgid "Failed to verify signature."
    241241msgstr ""
    242242
     243#: ps/ModIo.cpp:856
     244msgid "Invalid signature."
     245msgstr ""
     246
    243247#: ps/SavedGame.cpp:142
    244248#, c-format
    245249msgid "Saved game to '%s'"

Attachments (1)

mod.png (103.0 KB ) - added by Langbart 16 months ago.

Download all attachments as: .zip

Change History (7)

by Langbart, 16 months ago

Attachment: mod.png added

comment:1 by Stan, 16 months ago

Patch: Phab:D4918

comment:2 by Stan, 16 months ago

Owner: set to Stan
Status: newassigned

comment:3 by Stan, 16 months ago

Fixed the signature.

comment:4 by Stan, 16 months ago

Summary: 0ad-spirv invalid signature A27Invalid mod messages are not properly translated

comment:5 by Stan, 13 months ago

Milestone: Alpha 27Alpha 28

comment:6 by Stan, 11 months ago

Milestone: Alpha 28Alpha 27

Push back

Note: See TracTickets for help on using tickets.