Unit hotkeys: UI and implementation errors

[Alex Theodoulidis]

Civilization: Iberians, Unit: Kantabriako Zaldun (example)

After a unit is selected, moving the cursor on a command's icon shows a description of the command and the corresponding hotkey inside brackets.

Although the attack command (three blades icon) is given by pressing Ctrl, the brackets are empty. Instead, [Ctrl] is shown on the garrison command (door and arrow icon). This is a UI problem.

Regarding the implementation errors, one I have found is the following: if a unit has gathered the maximum amount of meat from a deer and we use the "Return to Work" command (Y), the unit will not return to the city center to deliver the meat, but hunt a new deer. When the deer is dead, it will then deliver the previous collected meat.

Not a serious issue nonetheless.

[Langbart]

Replying to Alex Theodoulidis:

Although the attack command (three blades icon) is given by pressing Ctrl, the brackets are empty. Instead, [Ctrl] is shown on the garrison command (door and arrow icon). This is a UI problem.

The attack-move is set by default to ctrl.

No hotkey is assigned to calltoarms by default, which is similar to attack-move but not the same.

---

The ticket is still valid, the user does not know the name of the hotkey (calltoarms) to change it, and the description suggests that it has something to do with attack-move.

Course of action could be to adjust the description by including the phrase call to arms, change the cursor to rather than and also give a default hotkey, e.g. Alt-a.

[Freagarach]

I remember there being a placeholder for non-set hotkeys? (With the hotkey identifier.)

[Langbart]

Replying to Freagarach:

I remember there being a placeholder for non-set hotkeys? (With the hotkey identifier.)

bisect

[24668]

possible solution

• use Array.prototype.{flat,flatMap} (added with ​ECMA 2019, ​Spidermonkey 62)

  binaries/data/mods/public/gui/common/color.js

  @@ -175 +175 @@
       // TODO: Be more efficient in retrieving the mapping(s) for a specific hotkey
       let key = Engine.GetHotkeyMap()[hotkey];
   
  -    if (!key)
  +    if (!key?.flat().length)
           key = sprintf(translate("Unassigned hotkey: %(hotkeyName)s"), {
               "hotkeyName": hotkey
           });