After queued construction of several fields, woman becomes idle

[Langbart]

to reproduce

• start a game with the Han select at least 4 women and task them to build two rice fields
  • You can also choose another civ, but then you would need 6 women
• hold the shift key pressed while giving the order
• when the second field is fully constructed, one woman becomes idle

bisect

[27559]

[Stan]

I think the bisect is incorrect. That commit even states it's gonna do that. It's an improvement over before where units would not build farms at all

[Langbart]

[27558]
Behaviour: Build foundations in the queue, and start farming on all fields.

[27559]
Behaviour: Build foundations in the queue, and all units that fit on the last field start farming, the rest become idle.

It's an improvement ...

[phosit]

In your example the last woman will:

Bevore [27559]: Constructing the fields -> try to garther from the most resent field (fail) -> try to work on the other field.

After [27559]: Constructing the fields -> peek if it's possible to work on the most resent field (it's not possible) -> search for other fundations to construct (fail) -> become idle.

[Langbart]

[27558]
If I have 8 Han women on the berries and they are almost done, I could select all the women, place 3 fields while holding down the shift key, and not have to worry about any of them ever becoming idle.
[27559]
Select all 8 women from the field, try to select 3 of them and give the queue order to build a farm when done. Try to select another 3 women do the same and another 2.

---

• more clicks, higher probability of idleness, and harder to micro manage your women

[Freagarach]

Yeah, the moment I saw the title of the ticket I saw the codepath in my mind. ^^'

[Freagarach]

In 27567:

Revert r27559 / rP27559.

Introduced #6750, reported by @Langbart, and quite hard to do right.
Fixes #6750