Invalid warning message for Kastasta

[obelix]

In Saharan Oases (4): When selecting the Kastasta (Farmstead) nearby your cc and right-clicking on its icon (the goat) the game prints a warning message. This only happens, when it's not already conquered resp. still under gaias sovereignty.

WARNING: Unrecognized phase (phase_city)

This confuses, especially new, gamers and should be changed.

See also: ​https://wildfiregames.com/forum/topic/107313-alpha-27-pre-releaserelease-candidate-build-testing/?do=findComment&comment=552843

I'll look at it, probably a mixup when I ported the files from DE to EA. (wowgetoffyourcellphone)

[Langbart]

• rather than template_structure_special_rotary_mill.xml create a mixin for these rotary_mills, see [25559] trading_post.xml and shrine.xml
  • the current issue you are inheriting from template_structure_special which sets requirements for phase_city, and you never change the <Civ> in your children
  • this interferes with TemplateParser.js, because there are no known phases for gaia

also important

• replace Gatherer class with Worker

binaries/data/mods/public/simulation/data/auras/structures/farmstead_60.json

@@ -1 +1 @@
 {
     "type": "range",
     "radius": 60,
-    "affects": ["Gatherer"],
+    "affects": ["Worker"],
     "modifications": [
         { "value": "ResourceGatherer/Rates/food.grain", "multiply": 1.75 }
     ],
     "auraName": "Farmland",
-    "auraDescription": "Gatherers +75% farming rate around a captured Farmstead.",
+    "auraDescription": "Workers +75% grain gather rate.",
     "overlayIcon": "art/textures/ui/session/auras/farm_bonus.png",
     "rangeOverlay" : {
         "lineTexture": "outline_border.png",

nitpicks

• remove redundant <Civ>gaia</Civ> string from templates
  • Ref: ​Phab:D1645, it is already inherited

[wowgetoffyourcellphone]

​https://code.wildfiregames.com/D5113

[abian]

It seems also related to #6853, is it so?

[wowgetoffyourcellphone]

In 27835:

Refactor Capturable Farmstead feature/templates

Attempts to address Invalid warning messages for capturable farmsteads and creates a mixin as suggested by @Langbart

Renames the "farmsteads_" template files to "mill_" to eliminate confusion with standard buildable farmsteads and changes the refs in the skirmish maps to suit.

Genericizes the name to Rotary Mill instead of Farmstead, again to eliminate confusion between the two (the former is a capturable map object, while the latter is a player-buildable structure).

Fixes #6818
Differential revision: ​https://code.wildfiregames.com/D5113