Opened 6 months ago

Closed 6 months ago

#6883 closed defect (fixed)

r27673 introduced serialization test failure

Reported by: Vladislav Belov Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 27
Component: Core engine Keywords:
Cc: Patch: Phab:D5181

Description (last modified by Vladislav Belov)

r27673 introduced serialization test failure (I've bisected it between 27104 and 27894):

Assertion failed: "0 && (L"Serialization test failure")"
Location: simulation2.cpp:334 (CSimulation2Impl::ReportSerializationFailure)

Full log: https://code.wildfiregames.com/P298

Reported for SVN head by @phosit: https://irclogs.wildfiregames.com/%230ad-dev/2023-10-25-QuakeNet-%230ad-dev.log

11:20 < phosit> Did somebody test the serializationtest in the last few months? It crashes as soon as the map is loaded.
11:21 < phosit> Assertion failed: "0 && (L"Serialization test failure")"
11:22 < Vladislav> phosit: you could try bisect.
11:23 < phosit> I can't build versions that are older then a few months
12:00 < Vladislav> phosit: if you can describe steps I can try to bisect tonight.
12:07 < phosit> just run `./binaries/system/pyrogenesis --serializationtest --autostart=scenarios/arcadia`
12:08 < phosit> `./binaries/system/pyrogenesis --serializationtest --autostart=scenarios/arcadia --autostart-nonvisual` also does not work but for a different reason

Change History (4)

comment:1 by Vladislav Belov, 6 months ago

Description: modified (diff)

comment:2 by Vladislav Belov, 6 months ago

Description: modified (diff)

comment:3 by Vladislav Belov, 6 months ago

Patch: Phab:D5181

comment:4 by wraitii, 6 months ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 27928:

Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization

This fixes an issue revealed by rP27673 that affected deserialized games.
Adding tests further highlighted a bug in the calculations, which is fixed.

Reviewed By: phosit

Fixes #6883

Differential Revision: https://code.wildfiregames.com/D5181

Note: See TracTickets for help on using tickets.