Opened 13 years ago
Closed 13 years ago
#734 closed task (fixed)
Upgrade SpiderMonkey again
| Reported by: | Philip Taylor | Owned by: | philip |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 7 |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: |
Description
Should upgrade it some time, to get bug fixes and performance improvements etc.
Some notes that I don't want to forget:
- Use
JS_NewCompartmentAndGlobalObjectfor the first context per runtime (to make them all share a compartment). JS_THREADSAFE(and NSPR) is obligatory.- Setter change.
- JS_GetStringChars is dead.
Attachments (3)
Change History (9)
by , 13 years ago
| Attachment: | sm-upgrade.diff added |
|---|
comment:1 by , 13 years ago
by , 13 years ago
| Attachment: | sm-upgrade2.diff added |
|---|
by , 13 years ago
comment:2 by , 13 years ago
To test:
- Apply the patch (probably
patch -p1 < sm-upgrade2.diffor something). - Create
libraries/spidermonkey/ - Save
build.shin there. - Save js185 in there (don't extract it manually).
- Run
build.shfrom its directory; that should successfully build SpiderMonkey. - Do a clean rebuild of the game.
The problem I get is that all the script-created widgets in Atlas are stuck at position (0,0), like their sizers aren't automatically running their layout code, and I have no idea why.
comment:3 by , 13 years ago
| Milestone: | Backlog → Alpha 6 |
|---|
comment:4 by , 13 years ago
| Milestone: | Alpha 6 → Alpha 7 |
|---|
comment:5 by , 13 years ago
| Owner: | set to |
|---|
comment:6 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [9852]) Upgrade to SpiderMonkey 1.8.5 (fixes #734)
Note:
See TracTickets
for help on using tickets.
This mostly works with 9aac1cc64794, except for profiling of functions registered by
InterfaceScripted.h. Also the warning disabling is ugly, and I haven't tested on Windows, and this probably won't work withJS_THREADSAFEyet.Performance improvements seem negligible so I don't care enough to finish this off yet.