Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#744 closed enhancement (fixed)

[PATCH] Button "Find idle workers"

Reported by: veprbl Owned by:
Priority: If Time Permits Milestone: Alpha 5
Component: Core engine Keywords: gui
Cc: Patch:

Description

  • Better button placement
  • Try to look for the nearest free worker
  • Display idle female citizens count on the button
  • Interface which displays all idle workers

Attachments (2)

free_worker-27-02-2011.diff​ (6.0 KB ) - added by veprbl 13 years ago.
free_worker-28-02-2011.diff​ (4.5 KB ) - added by veprbl 13 years ago.

Download all attachments as: .zip

Change History (13)

by veprbl, 13 years ago

Attachment: free_worker-27-02-2011.diff​ added

by veprbl, 13 years ago

Attachment: free_worker-28-02-2011.diff​ added

comment:1 by fabio, 13 years ago

Milestone: Backlog → Alpha 5

comment:2 by historic_bruno, 13 years ago

Keywords: review added

comment:3 by Philip Taylor, 13 years ago

Thanks for this, and sorry for being slow at reviewing it. I just made some minor changes:

  • Moved the button, so it's still visible at 1024x768.
  • Added hotkey.
  • Renamed "free" to "idle" since that seems to be the standard terminology.
  • Changed it to save the last-selection state in the GUI instead of the simulation scripts, since that's more flexible (e.g. the GUI could call FindIdleWorker(0) every frame to figure out whether there are any, without affecting the selection state).
  • Changed it to use CameraFollow instead of SetCameraTarget, since I think it's nice to keep focus on the unit once you order it to move, unless people find that really irritating. (Also SetCameraTarget didn't work if the camera was rotated.)

comment:4 by philip, 13 years ago

Resolution: → fixed
Status: new → closed

(In [9140]) # Add idle worker button, based on patch from veprbl. Fixes #744.

comment:5 by Erik Johansson, 13 years ago

Hmm, I actually think it is pretty irritating :P It might be a nice feature if it would stop following the unit once you clicked on something else though and not have to move the camera.

comment:6 by Kieran P, 13 years ago

Agreed. If you click on something else, it stops the follow. The button itself is kinda ugly and in a bad location. Personally, I'd make all maps round, and use the space around the map circle to place 4 buttons.

Other than that though, and combined with silhouettes, no more lost units! It's great!

comment:7 by Kieran P, 13 years ago

(made #775)

comment:8 by Erik Johansson, 13 years ago

Not sure if I should open a new ticket for this or what, but it would be nice to be able to find all idle units. My suggestion would be to group them like this: "Idle Warriors" (heroes, super units, siege, war ships), Idle Citizen Soldiers, Idle Support Units (female citizens, healers, traders, fishing ships, trade ships). Not sure about how to graphically represent it the best way, but it would work good with the keys: , . - (,=warriors; .=citizen soldiers; -=support units). Thoughts?

in reply to:  8 comment:9 by Philip Taylor, 13 years ago

Replying to feneur:

Not sure if I should open a new ticket for this

You should, else the suggestion will almost certainly get lost :-)

comment:10 by Erik Johansson, 13 years ago

Then I will :-)

comment:11 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.