Opened 13 years ago
Closed 13 years ago
#793 closed defect (fixed)
Random maps don't report name
Reported by: | Philip Taylor | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 5 |
Component: | Core engine | Keywords: | |
Cc: | historic_bruno | Patch: |
Description
session.js
has reportPerformance
which uses Engine.GetMapSettings().Name
to say what map the profiling data applies to. When playing random maps, the Name
seems to be undefined. I expect it would be best if that was the name of the random map script, and maybe reportPerformance
should report the size and seed too, so we could (in theory) detect whether certain maps have significant performance problems.
Change History (3)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
That sounds sensible - I'm happy with any method that returns enough data to identify the map.
comment:3 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
The first part is easy to fix. But what do you think about using the initData that gets passed to sessions instead of Engine.GetMapSettings()? It doesn't return all the data, like map type. Map type could be tested for "random" and in that case, the seed and map size could be included.