Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#805 closed enhancement (fixed)

[PATCH] Support double-click on unit group buttons

Reported by: Philip Taylor Owned by:
Priority: Should Have Milestone: Alpha 6
Component: Core engine Keywords: simple
Cc: Patch:

Description

When you assign unit groups (with ctrl+1 etc) it shows a little numbered button at the side of the screen. Double-clicking the button should have the same effect as double-pressing the digit key (i.e. move the camera to the units).

This probably needs some changes to the GUI engine, particularly IGUIButtonBehavior::HandleMessage to detect double-clicks and send a different message type (GUIM_DOUBLE_PRESSED, script event doublepress or something, probably in addition to the standard press event (since some other buttons want to treat it like two separate presses)), then updateGroups in mods/public/gui/session/session.js should set button.ondoublepress appropriately.

Attachments (2)

doublepress.patch (1.6 KB ) - added by Markus Eronen 13 years ago.
doublepress_alt_modularity.patch (1.4 KB ) - added by Markus Eronen 13 years ago.
alternative patch with more similarities to the original code

Download all attachments as: .zip

Change History (9)

by Markus Eronen, 13 years ago

Attachment: doublepress.patch added

comment:1 by Markus Eronen, 13 years ago

Keywords: review added

comment:2 by Markus Eronen, 13 years ago

Keywords: simple review → simple, review

by Markus Eronen, 13 years ago

alternative patch with more similarities to the original code

comment:3 by Erik Johansson, 13 years ago

Summary: Support double-click on unit group buttons[PATCH] Support double-click on unit group buttons

comment:4 by Badmadblacksad, 13 years ago

Resolution: fixed
Status: newclosed

(In [9592]) Support double-click on unit group buttons. patch by Merolum. fixes #805.

comment:5 by Kieran P, 13 years ago

Milestone: BacklogAlpha 6

comment:6 by philip, 13 years ago

(In [9604]) Fix #805 more so it doesn't ignore the second click on non-double-clickable buttons.

comment:7 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.