Disable FoW for AI players

[Philip Taylor]

r9657 made UnitAI take account of FoW and refuse to move to targets unless they're visible. The AI players cheat and ignore FoW (to avoid a load of extra complexity and pain), but now their units will probably refuse orders and cause confusion if the AI decides to attack a hidden enemy. Things should be changed so the whole map is always revealed (from the perspective of GetLosVisibility at least) to AI players.

[Kieran P]

I don't agree. I think the AI's should be limited to what players can do, and require that they send out scouts, just like everyone has to. Same would apply for AI harvesting. They need to find the resources first.

[James Baillie]

Sooo, I should start getting the AI making scouts then?

[Philip Taylor]

In an ideal world the AI would be perfectly fair and respect FoW, but I expect that would add a huge amount of complexity to the AI implementation so it's not something we should do now.

[Philip Taylor]

I think Gaia needs to act as if everything is visible, too.

[philip]

(In [9720]) Add per-player LOS-reveal flag. Reveal LOS for Gaia and AI players (fixes #879). Use player_id_t slightly more consistently in interfaces.