Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#887 closed enhancement (wontfix)

[PATCH] Catch terrain patch vertex height for water rendering

Reported by: kromxp Owned by: philip
Priority: Should Have Milestone: Alpha 7
Component: Core engine Keywords: patch
Cc: Patch:

Description

The proposed small patch catches the vertex heights of the patches used.

When rendering water if there is not any vertex below water level, the whole patch is skipped. For the patches that are shown, their height levels are cached and faster to access.

It also fixes the // TODO: stop using g_Game

An improvement by using this patch could be to only call the TerrainRenderer::RenderWater if any of the patches has been submitted to be rendered with any vertex below water level.

Attachments (1)

catch-patch-vertex-height.patch (4.4 KB ) - added by kromxp 13 years ago.

Download all attachments as: .zip

Change History (7)

by kromxp, 13 years ago

comment:1 by Kieran P, 13 years ago

Milestone: Alpha 6Alpha 7

comment:2 by Kieran P, 13 years ago

Owner: set to kromxp

comment:3 by Kieran P, 13 years ago

Keywords: patch added

comment:4 by Kieran P, 13 years ago

Owner: changed from kromxp to philip

Work is included in or made obsolete by eihrul_'s frakenpatch. See http://lee.fov120.com/0ad-frankenpatch.diff . Ticket will be closed once frankenpatch is reviewed and committed.

comment:5 by Philip Taylor, 13 years ago

Resolution: wontfix
Status: newclosed

r9814 changes the water renderer so I don't think this is needed any more.

comment:6 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.