Assertion failure on allocating 0 bytes from pool when rendering terrain

[iznogood]

Hi. When I start the game I can see the menu, but when I try to start to play on a map I got an error at the end of the loading.

[iznogood]

GDB full bt : http://pastebin.com/Nnq2NMBp

[iznogood]

Don't worry about the animation or xml file that are not found, they are not the problem.

Obviously an assert in pool_alloc fails. But I can't say why.

[Philip Taylor]

#7  0x08335a67 in pool_alloc (p=0xbfec72e0, size=0) at ../../../source/lib/allocators/pool.cpp:96

The size=0 seems to trigger that assertion failure. Not sure why it's allocating 0 bytes, but I suppose there's no reason why the STL implementation shouldn't be allowed to do that.

I assume the solution is to handle size=0 correctly, i.e. return a unique pointer, by clamping size to 1 or something. Should that clamping happen in pool_alloc, or in RawPoolAllocator, or in pool_allocator?

[Jan Wassenberg]

(In [9944]) pool - safely handle zero-sized allocations (fixes #909) snd_mgr - remove no longer needed hacks for native OpenAL implementations test_wdbg_sym.h - belated commit of warning fix

[Jan Wassenberg]

Thanks for the backtrace! I've changed pool_allocator to treat 0 as 1; that'll guarantee a unique address, as required by C++. Please reopen if this did not fix the problem.