Ticket #1963: fix-no-gain-for-unfinished-market.patch

trunk/binaries/data/mods/public/gui/session/input.js

@@ -263 +263 @@
                 (!hasClass(entState, "NavalMarket") || hasClass(targetState, "NavalMarket")))
         {
             // Find a trader (if any) that this building can produce.
-            var trader;
+            var trader = null;
             if (entState.production && entState.production.entities.length)
                 for (var i = 0; i < entState.production.entities.length; ++i)
                     if ((trader = GetTemplateData(entState.production.entities[i]).trader))
                         break;
 
-            var traderData = { "firstMarket": entState.id, "secondMarket": targetState.id, "template": trader };
-            var gain = Engine.GuiInterfaceCall("GetTradingRouteGain", traderData);
-            if (gain !== null)
+            if (trader !== null)
             {
-                data.command = "trade";
-                data.target = traderData.secondMarket;
-                data.source = traderData.firstMarket;
-                cursor = "action-setup-trade-route";
-                tooltip = "Click to establish a default route for new traders. Gain: " + gain + " metal.";
+                var traderData = { "firstMarket": entState.id, "secondMarket": targetState.id, "template": trader };
+                var gain = Engine.GuiInterfaceCall("GetTradingRouteGain", traderData);
+                if (gain !== null)
+                {
+                    data.command = "trade";
+                    data.target = traderData.secondMarket;
+                    data.source = traderData.firstMarket;
+                    cursor = "action-setup-trade-route";
+                    tooltip = "Click to establish a default route for new traders. Gain: " + gain + " metal.";
+                }
             }
         }