Ticket #3203: t3203_autocomplete_observer_nicknames_alternative.patch

File t3203_autocomplete_observer_nicknames_alternative.patch, 1.9 KB (added by elexis, 9 years ago)

Array comprehension doesn't seem possible, because the g_PlayerAssignments object can't be iterated with "of". This patch is a tiny bit simpler.

  • binaries/data/mods/public/gui/gamesetup/gamesetup.xml

     
    187187
    188188                <object name="chatInput" size="4 100%-24 100%-76 100%-4" type="input" style="ModernInput">
    189189                    <action on="Press">submitChatInput();</action>
    190190                    <action on="Tab">
    191191                        var players = [];
    192                         for (var player in g_PlayerAssignments)
    193                             players.push(g_PlayerAssignments[player]);
     192                        for each (let player in g_PlayerAssignments)
     193                            players.push(player);
    194194                        autoCompleteNick("chatInput", players);
    195195                    </action>
    196196                </object>
    197197
    198198                <object size="100%-72 100%-24 100%-4 100%-4" type="button" style="StoneButton">
  • binaries/data/mods/public/gui/session/session.xml

     
    195195
    196196    <!-- Chat window -->
    197197    <object name="chatDialogPanel" size="50%-180 50%-48 50%+180 50%+36" type="image" hidden="true" sprite="genericPanel">
    198198        <object name="chatInput" size="16 12 100%-16 36" type="input" style="ModernInput" max_length="80">
    199199            <action on="Press">submitChatInput();</action>
    200             <action on="Tab">autoCompleteNick("chatInput", g_Players);</action>
     200            <action on="Tab">
     201                var players = [];
     202                for each (let player in g_PlayerAssignments)
     203                    players.push(player);
     204                autoCompleteNick("chatInput", players);
     205            </action>
    201206        </object>
    202207
    203208        <object size="16 100%-40 30%+16 100%-12" type="button" style="StoneButton">
    204209            <translatableAttribute id="caption">Cancel</translatableAttribute>
    205210            <action on="Press">closeChat();</action>