Ticket #3395: ticket3395unitactions_7.diff

File ticket3395unitactions_7.diff, 4.4 KB (added by bb, 8 years ago)

ratio --> rate, cleanup from previous commit. Last patch needs to be rebased after this one.

  • binaries/data/mods/public/gui/common/tooltips.js

     
    229229    return attacks.join("\n");
    230230}
    231231
    232 function getRepairRatioTooltip(ratio)
     232function getRepairRateTooltip(rate)
    233233{
    234     let unit = sprintf(translate("%(health)s / %(second)s / %(worker)s"), {
     234    let detail = Math.round(rate * 10) / 10;
     235    return "\n" + sprintf(translate("%(repairRateLabel)s %(detail)s %(health)s / %(second)s / %(worker)s"), {
     236        "repairRateLabel": g_TooltipTextFormats.header[0] + translate("Repair Rate:") + g_TooltipTextFormats.header[1],
     237        "detail": detail,
    235238        "health": g_TooltipTextFormats.unit[0] + translate("health") + g_TooltipTextFormats.unit[1],
    236239        "second": g_TooltipTextFormats.unit[0] + translate("second") + g_TooltipTextFormats.unit[1],
    237240        "worker": g_TooltipTextFormats.unit[0] + translate("worker") + g_TooltipTextFormats.unit[1]
    238241    });
    239 
    240     return "\n" + sprintf(translate("%(repairRateLabel)s %(detail)s %(unit)s"), {
    241         "repairRateLabel": g_TooltipTextFormats.header[0] + translate("Repair Rate:") + g_TooltipTextFormats.header[1],
    242         "detail": ratio,
    243         "unit": unit
    244     });
    245242}
    246243
    247244/**
  • binaries/data/mods/public/gui/session/selection_details.js

     
    262262    Engine.GetGUIObjectByName("attackAndArmorStats").tooltip = entState.attack ? (getAttackTooltip(entState) + "\n" + armorString) : armorString;
    263263
    264264    // Repair Rate
    265     if (entState.repairRatio)
    266         Engine.GetGUIObjectByName("attackAndArmorStats").tooltip += getRepairRatioTooltip(entState.repairRatio);
     265    if (entState.repairRate)
     266        Engine.GetGUIObjectByName("attackAndArmorStats").tooltip += getRepairRateTooltip(entState.repairRate);
    267267
    268268    // Icon Tooltip
    269269    let iconTooltip = "";
  • binaries/data/mods/public/simulation/components/GuiInterface.js

     
    404404        "obstruction": null,
    405405        "turretParent":null,
    406406        "promotion": null,
    407         "repairTime": null,
     407        "repairRate": null,
    408408        "resourceDropsite": null,
    409409        "resourceGatherRates": null,
    410410        "resourceSupply": null,
     
    487487
    488488    let cmpRepairable = Engine.QueryInterface(ent, IID_Repairable);
    489489    if (cmpRepairable)
    490         ret.repairRatio = cmpRepairable.GetRepairRatio();
     490        ret.repairRate = cmpRepairable.GetRepairRate();
    491491
    492492    let cmpResourceSupply = QueryMiragedInterface(ent, IID_ResourceSupply);
    493493    if (cmpResourceSupply)
  • binaries/data/mods/public/simulation/components/Repairable.js

     
    7474        Engine.PostMessage(this.entity, MT_ConstructionFinished, { "entity": this.entity, "newentity": this.entity });
    7575};
    7676
    77 Repairable.prototype.GetRepairRatio = function()
     77Repairable.prototype.GetRepairRate = function()
    7878{
    7979    let cmpHealth = Engine.QueryInterface(this.entity, IID_Health);
    8080    let cmpCost = Engine.QueryInterface(this.entity, IID_Cost);
    8181    let repairTime = this.repairTimeRatio * cmpCost.GetBuildTime();
    82     let repairRatio = (cmpHealth.GetMaxHitpoints() / repairTime);
    83     return (Math.round(repairRatio * 10 ) / 10);
     82    let repairRate = cmpHealth.GetMaxHitpoints() / repairTime;
     83    return repairRate;
    8484};
    8585
    8686Engine.RegisterComponentType(IID_Repairable, "Repairable", Repairable);
  • binaries/data/mods/public/simulation/components/tests/test_GuiInterface.js

     
    510510    obstruction: null,
    511511    turretParent: null,
    512512    promotion: null,
    513     repairTime: null,
     513    repairRate: null,
    514514    resourceDropsite: null,
    515515    resourceGatherRates: null,
    516516    resourceSupply: null,