Ticket #3934: resource_agnostic.patch

new file inaries/data/mods/public/gui/common/functions_repeat_positioning.js

@@ +1 @@
+/*
+    DESCRIPTION : Functions related to positioning UI elements
+    NOTES       :
+*/
+
+/**
+ * Horizontally fit objects repeated with the `<repeat>` tag within a parent object
+ * 
+ * @param basename The base name of the object, such as "object[n]" or "object[a]_sub[b]"
+ * @param splitvar The var identifying the repeat count, without the square brackets
+ * @param margin The gap, in px, between the repeated objects
+ * @param limit The number of elements to fit
+ * @return The number of elements affected
+ */
+function horizFitRepeatedObjects(basename, splitvar="n", margin=0, limit=0)
+{
+    basename = basename.split("["+splitvar+"]", 2);
+
+    var objObj;
+    if (limit == 0)
+        do
+        {
+            objObj = Engine.GetGUIObjectByName(basename.join("["+ ++limit +"]"));
+        }
+        while (objObj)
+
+    for (let c = 0; c < limit; ++c)
+    {
+        objObj = Engine.GetGUIObjectByName(basename.join("["+ c +"]"));
+        let objSize = objObj.size;
+        objSize.rleft = c * (100/limit);
+        objSize.rright = (c+1) * (100/limit);
+        objSize.right = -margin;
+        objObj.size = objSize;
+    }
+
+    return limit;
+}
+
+/**
+ * Hide all repeated elements after a certain index
+ * 
+ * @param prefix The part of the element name preceeding the index
+ * @param idx The index from which to start
+ * @param prefix The part of the element name after the index
+ */
+function hideRemaining(prefix, idx, suffix)
+{
+    for (;; ++idx)
+    {
+        let obj = Engine.GetGUIObjectByName(prefix+idx+suffix);
+        if (!obj)
+            return;
+        obj.hidden = true;
+    }
+}

binaries/data/mods/public/gui/common/l10n.js

@@ -1 @@
-const localisedResourceNames = {
-    "firstWord": {
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "food": translateWithContext("firstWord", "Food"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "meat": translateWithContext("firstWord", "Meat"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "metal": translateWithContext("firstWord", "Metal"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "ore": translateWithContext("firstWord", "Ore"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "rock": translateWithContext("firstWord", "Rock"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "ruins": translateWithContext("firstWord", "Ruins"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "stone": translateWithContext("firstWord", "Stone"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "treasure": translateWithContext("firstWord", "Treasure"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "tree": translateWithContext("firstWord", "Tree"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "wood": translateWithContext("firstWord", "Wood"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "fruit": translateWithContext("firstWord", "Fruit"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "grain": translateWithContext("firstWord", "Grain"),
-        // Translation: Word as used at the beginning of a sentence or as a single-word sentence.
-        "fish": translateWithContext("firstWord", "Fish"),
-    },
-    "withinSentence": {
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "food": translateWithContext("withinSentence", "Food"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "meat": translateWithContext("withinSentence", "Meat"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "metal": translateWithContext("withinSentence", "Metal"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "ore": translateWithContext("withinSentence", "Ore"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "rock": translateWithContext("withinSentence", "Rock"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "ruins": translateWithContext("withinSentence", "Ruins"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "stone": translateWithContext("withinSentence", "Stone"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "treasure": translateWithContext("withinSentence", "Treasure"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "tree": translateWithContext("withinSentence", "Tree"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "wood": translateWithContext("withinSentence", "Wood"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "fruit": translateWithContext("withinSentence", "Fruit"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "grain": translateWithContext("withinSentence", "Grain"),
-        // Translation: Word as used in the middle of a sentence (which may require using lowercase for your language).
-        "fish": translateWithContext("withinSentence", "Fish"),
-    }
-};
 
 function getLocalizedResourceName(resourceCode, context)
 {
-    if (!localisedResourceNames[context])
-    {
-        warn("Internationalization: Unexpected context for resource type localization found: ‘" + context + "’. This context is not supported.");
-        return resourceCode;
-    }
-    if (!localisedResourceNames[context][resourceCode])
-    {
-        warn("Internationalization: Unexpected resource type found with code ‘" + resourceCode + ". This resource type must be internationalized.");
-        return resourceCode;
-    }
-    return localisedResourceNames[context][resourceCode];
+    return translateWithContext(context, resourceCode);
 }
 
 /**
@@ -81 +13 @@
         .filter(type => resources[type] > 0)
         .map(type => sprintf(translate("%(amount)s %(resourceType)s"), {
             "amount": resources[type],
-            "resourceType": getLocalizedResourceName(type, "withinSentence")
+            "resourceType": translateWithContext("withinSentence", type)
         }));
 
     if (amounts.length > 1)

binaries/data/mods/public/gui/common/setup_resources.xml

@@ -2 +2 @@
 
 <setup>
     <!-- Icons -->
-    <icon name="iconFood"
+    <icon name="icon_food"
           sprite="stretched:session/icons/resources/food_small.png"
           size="16 16"
     />
-    <icon name="iconMetal"
+    <icon name="icon_metal"
           sprite="stretched:session/icons/resources/metal_small.png"
           size="16 16"
     />
-    <icon name="iconPopulation"
+    <icon name="icon_population"
           sprite="stretched:session/icons/resources/population_small.png"
           size="16 16"
     />
-    <icon name="iconStone"
+    <icon name="icon_stone"
           sprite="stretched:session/icons/resources/stone_small.png"
           size="16 16"
     />
-    <icon name="iconWood"
+    <icon name="icon_wood"
           sprite="stretched:session/icons/resources/wood_small.png"
           size="16 16"
     />
-    <icon name="iconTime"
+    <icon name="icon_time"
           sprite="stretched:session/icons/resources/time_small.png"
           size="16 16"
     />

binaries/data/mods/public/gui/common/tooltips.js

@@ -1 @@
-const g_CostDisplayIcons = {
-    "food": '[icon="iconFood"]',
-    "wood": '[icon="iconWood"]',
-    "stone": '[icon="iconStone"]',
-    "metal": '[icon="iconMetal"]',
-    "population": '[icon="iconPopulation"]',
-    "time": '[icon="iconTime"]'
-};
 
 const g_TooltipTextFormats = {
     "unit": ['[font="sans-10"][color="orange"]', '[/color][/font]'],
@@ -260 +252 @@
  */
 function getCostComponentDisplayIcon(costComponentName)
 {
-    if (costComponentName in g_CostDisplayIcons)
-        return g_CostDisplayIcons[costComponentName];
-
-    warn(sprintf("The specified cost component, ‘%(component)s’, is not currently supported.", { "component": costComponentName }));
-    return "";
+    return "[icon=\"icon_"+costComponentName+"\"]";
 }
 
 /**
@@ -291 +279 @@
     totalCosts.time = Math.ceil(template.cost.time * (entity ? Engine.GuiInterfaceCall("GetBatchTime", { "entity": entity, "batchSize": trainNum }) : 1));
 
     let costs = [];
-
-    for (let type in g_CostDisplayIcons)
-        if (totalCosts[type])
-            costs.push(sprintf(translate("%(component)s %(cost)s"), {
-                "component": getCostComponentDisplayIcon(type),
-                "cost": totalCosts[type]
-            }));
+    
+    for (let c in template.cost)
+        if (c === "populationBonus")
+            continue;
+        else if (totalCosts[c])
+            if (typeof GetSimState === "undefined" || GetSimState().resources.indexOf(c) > -1 || c === "time")
+                costs.push(sprintf(translate("%(component)s %(cost)s"), {
+                    "component": getCostComponentDisplayIcon(c),
+                    "cost": totalCosts[c]
+                }));
 
     return costs;
 }

binaries/data/mods/public/gui/session/diplomacy_window.xml

@@ -11 +11 @@
     </object>
 
     <object name="diplomacyHeader" size="32 32 100%-32 64">
-        <object name="diplomacyHeaderName" size="0 0 150 100%" type="text" style="chatPanel" ghost="true">
+        <object name="diplomacyHeaderName" size="0 0 140 100%" type="text" style="chatPanel" ghost="true" text_align="center">
             <translatableAttribute id="caption">Name</translatableAttribute>
         </object>
         <object name="diplomacyHeaderCiv" size="150 0 250 100%" type="text" style="chatPanel" ghost="true">
@@ -23 +23 @@
         <object name="diplomacyHeaderTheirs" size="300 0 360 100%" type="text" style="chatPanel" ghost="true">
             <translatableAttribute id="caption">Theirs</translatableAttribute>
         </object>
-        <object name="diplomacyHeaderAlly" size="100%-180 0 100%-160 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
+        <object name="diplomacyHeaderAlly" size="360 0 380 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
             <translatableAttribute id="caption">A</translatableAttribute>
             <translatableAttribute id="tooltip">Ally</translatableAttribute>
         </object>
-        <object name="diplomacyHeaderNeutral" size="100%-160 0 100%-140 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
+        <object name="diplomacyHeaderNeutral" size="380 0 400 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
             <translatableAttribute id="caption">N</translatableAttribute>
             <translatableAttribute id="tooltip">Neutral</translatableAttribute>
         </object>
-        <object name="diplomacyHeaderEnemy" size="100%-140 0 100%-120 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
+        <object name="diplomacyHeaderEnemy" size="400 0 420 100%" type="text" style="chatPanel" tooltip_style="sessionToolTipBold">
             <translatableAttribute id="caption">E</translatableAttribute>
             <translatableAttribute id="tooltip">Enemy</translatableAttribute>
         </object>
-        <object name="diplomacyHeaderTribute" size="100%-110 0 100% 100%" type="text" style="chatPanel">
+        <object name="diplomacyHeaderTribute" size="430 0 100%-30 100%" type="text" style="chatPanel" text_align="center">
             <translatableAttribute id="caption">Tribute</translatableAttribute>
         </object>
     </object>
@@ -48 +48 @@
                 <object name="diplomacyPlayerTheirs[n]" size="300 0 360 100%" type="text" style="chatPanel" ghost="true"/>
 
                 <!-- Diplomatic stance - selection -->
-                <object name="diplomacyPlayerAlly[n]" size="100%-180 0 100%-160 100%" type="button" style="StoneButton" hidden="true"/>
-                <object name="diplomacyPlayerNeutral[n]" size="100%-160 0 100%-140 100%" type="button" style="StoneButton" hidden="true"/>
-                <object name="diplomacyPlayerEnemy[n]" size="100%-140 0 100%-120 100%" type="button" style="StoneButton" hidden="true"/>
+                <object name="diplomacyPlayerAlly[n]" size="360 0 380 100%" type="button" style="StoneButton" hidden="true"/>
+                <object name="diplomacyPlayerNeutral[n]" size="380 0 400 100%" type="button" style="StoneButton" hidden="true"/>
+                <object name="diplomacyPlayerEnemy[n]" size="400 0 420 100%" type="button" style="StoneButton" hidden="true"/>
 
-                <!-- Tribute -->
-                <object name="diplomacyPlayerTributeFood[n]" size="100%-110 0 100%-90 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">
-                    <object name="diplomacyPlayerTributeFoodImage[n]" type="image" size="0 0 100% 100%" sprite="stretched:session/icons/resources/food.png" ghost="true"/>
-                </object>
-                <object name="diplomacyPlayerTributeWood[n]" size="100%-90 0 100%-70 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">
-                    <object name="diplomacyPlayerTributeWoodImage[n]" type="image" size="0 0 100% 100%" sprite="stretched:session/icons/resources/wood.png" ghost="true"/>
-                </object>
-                <object name="diplomacyPlayerTributeStone[n]" size="100%-70 0 100%-50 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">
-                    <object name="diplomacyPlayerTributeStoneImage[n]" type="image" size="0 0 100% 100%" sprite="stretched:session/icons/resources/stone.png" ghost="true"/>
-                </object>
-                <object name="diplomacyPlayerTributeMetal[n]" size="100%-50 0 100%-30 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">
-                    <object name="diplomacyPlayerTributeMetalImage[n]" type="image" size="0 0 100% 100%" sprite="stretched:session/icons/resources/metal.png" ghost="true"/>
+                <!-- Tribute --> 
+                <object size="430 0 100%-40 100%">
+                    <repeat count="8" var="r">
+                        <object name="diplomacyPlayer[n]_tribute[r]" size="0 0 20 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">
+                            <object name="diplomacyPlayer[n]_tribute[r]_image" type="image" size="0 0 100% 100%" ghost="true"/>
+                        </object>
+                    </repeat>
                 </object>
 
                 <object name="diplomacyAttackRequest[n]" size="100%-20 0 100% 100%" type="button" style="iconButton" tooltip_style="sessionToolTipBold" hidden="true">

binaries/data/mods/public/gui/session/menu.js

@@ -22 +22 @@
 // Number of pixels per millisecond to move
 const MENU_SPEED = 1.2;
 
-// Available resources in trade and tribute menu
-const RESOURCES = ["food", "wood", "stone", "metal"];
-
 // Trade menu: step for probability changes
 const STEP = 5;
 
@@ -265 +262 @@
     g_IsDiplomacyOpen = true;
 
     let isCeasefireActive = GetSimState().ceasefireActive;
+    let resCodes = GetSimState().resources;
 
     // Get offset for one line
     let onesize = Engine.GetGUIObjectByName("diplomacyPlayer[0]").size;
@@ -283 +281 @@
         diplomacyFormatAttackRequestButton(i, myself || playerInactive || isCeasefireActive || !hasAllies || !g_Players[i].isEnemy[g_ViewedPlayer]);
     }
 
-    Engine.GetGUIObjectByName("diplomacyDialogPanel").hidden = false;
+    let dialog = Engine.GetGUIObjectByName("diplomacyDialogPanel");
+    let size = dialog.size;
+    let wid = resCodes.length * 10;
+    size.left = -(260 + wid);
+    size.right = (260 + wid);
+    dialog.size = size;
+    dialog.hidden = false;
 }
 
 function diplomacySetupTexts(i, rowsize)
@@ -329 +333 @@
 
 function diplomacyFormatTributeButtons(i, hidden)
 {
-    for (let resource of RESOURCES)
+    let resCodes = GetSimState().resources;
+    for (let r in resCodes)
     {
-        let button = Engine.GetGUIObjectByName("diplomacyPlayerTribute"+resource[0].toUpperCase()+resource.substring(1)+"["+(i-1)+"]");
+        let resource = resCodes[r];
+        let button = Engine.GetGUIObjectByName("diplomacyPlayer["+(i-1)+"]_tribute["+r+"]");
+            Engine.GetGUIObjectByName("diplomacyPlayer["+(i-1)+"]_tribute["+r+"]_image").sprite = "stretched:session/icons/resources/"+resource+".png";
         button.hidden = hidden;
+        setPanelObjectPosition(button, r, 8, 0);
         if (hidden)
             continue;
 
@@ -351 +359 @@
                 }
 
                 let amounts = {};
-                for (let type of RESOURCES)
-                    amounts[type] = 0;
-                amounts[resource] = 100 * multiplier;
+                for (let res of resCodes)
+                    amounts[res] = 0;
+                amounts[resource] = 100 * multiplier,
 
                 button.tooltip = formatTributeTooltip(i, resource, amounts[resource]);
 
@@ -424 +432 @@
 
     var proba = Engine.GuiInterfaceCall("GetTradingGoods", g_ViewedPlayer);
     var button = {};
-    var selec = RESOURCES[0];
-    for (var i = 0; i < RESOURCES.length; ++i)
+    let resCodes = GetSimState().resources;
+    let selec = resCodes[0];
+    hideRemaining("tradeResource[", resCodes.length, "]");
+
+    for (let i = 0; i < resCodes.length; ++i)
     {
         var buttonResource = Engine.GetGUIObjectByName("tradeResource["+i+"]");
-        if (i > 0)
-        {
-            var size = Engine.GetGUIObjectByName("tradeResource["+(i-1)+"]").size;
-            var width = size.right - size.left;
-            size.left += width;
-            size.right += width;
-            Engine.GetGUIObjectByName("tradeResource["+i+"]").size = size;
-        }
-        var resource = RESOURCES[i];
+        setPanelObjectPosition(buttonResource, i, 8);
+        var resource = resCodes[i];
         proba[resource] = (proba[resource] ? proba[resource] : 0);
         var buttonResource = Engine.GetGUIObjectByName("tradeResourceButton["+i+"]");
         var icon = Engine.GetGUIObjectByName("tradeResourceIcon["+i+"]");
@@ -452 +456 @@
             return function() {
                 if (Engine.HotkeyIsPressed("session.fulltradeswap"))
                 {
-                    for (var ress of RESOURCES)
+                    for (let ress of resCodes)
                         proba[ress] = 0;
                     proba[resource] = 100;
                     Engine.PostNetworkCommand({"type": "set-trading-goods", "tradingGoods": proba});
@@ -488 +492 @@
     Engine.GetGUIObjectByName("landTraders").caption = getIdleLandTradersText(traderNumber);
     Engine.GetGUIObjectByName("shipTraders").caption = getIdleShipTradersText(traderNumber);
 
-    Engine.GetGUIObjectByName("tradeDialogPanel").hidden = false;
+    let dialog = Engine.GetGUIObjectByName("tradeDialogPanel");
+    let size = dialog.size;
+    let wid = resCodes.length * (58/2);
+    size.left = -(134 + wid);
+    size.right = (134 + wid);
+    dialog.size = size;
+    dialog.hidden = false;
 }
 
 function getIdleLandTradersText(traderNumber)

binaries/data/mods/public/gui/session/selection_panels.js

@@ -87 +87 @@
 g_SelectionPanels.Barter = {
     "getMaxNumberOfItems": function()
     {
-        return 4;
+        return 8;
     },
     "rowLength": 4,
     "getItems": function(unitEntState, selection)
     {
         if (!unitEntState.barterMarket)
             return [];
-        // ["food", "wood", "stone", "metal"]
-        return BARTER_RESOURCES;
+        return GetSimState().resources;
     },
     "setupButton": function(data)
     {
@@ -115 +114 @@
         if (Engine.HotkeyIsPressed("session.massbarter"))
             amountToSell *= BARTER_BUNCH_MULTIPLIER;
 
+        if (!g_BarterSell)
+            g_BarterSell = GetSimState().resources[0];
+
         amount.Sell.caption = "-" + amountToSell;
         let prices = data.unitEntState.barterMarket.prices;
         amount.Buy.caption = "+" + Math.round(prices.sell[g_BarterSell] / prices.buy[data.item] * amountToSell);
@@ -158 +160 @@
         button.Sell.hidden = false;
         selectionIcon.hidden = !isSelected;
 
-        setPanelObjectPosition(button.Sell, data.i, data.rowLength);
-        setPanelObjectPosition(button.Buy, data.i + data.rowLength, data.rowLength);
+        let sellPos = data.i + (data.i >= data.rowLength ? data.rowLength : 0);
+        let buyPos = data.i + data.rowLength * (data.i >= data.rowLength ? 2 : 1);
+        setPanelObjectPosition(button.Sell, sellPos, data.rowLength);
+        setPanelObjectPosition(button.Buy, buyPos, data.rowLength);
         return true;
     }
 };

binaries/data/mods/public/gui/session/selection_panels_helpers.js

@@ -2 +2 @@
 // Barter constants
 const BARTER_RESOURCE_AMOUNT_TO_SELL = 100;
 const BARTER_BUNCH_MULTIPLIER = 5;
-const BARTER_RESOURCES = ["food", "wood", "stone", "metal"];
 const BARTER_ACTIONS = ["Sell", "Buy"];
 
 // Gate constants
@@ -10 +9 @@
 
 // ==============================================
 // BARTER HELPERS
-// Resources to sell on barter panel
-var g_BarterSell = "food";
+// Resource to sell by default on barter panel
+// ! - cannot be set as we don't know the possible resources yet
+var g_BarterSell = null;
 
+// ==============================================
 // FORMATION HELPERS
 // Check if the selection can move into formation, and cache the result
 function canMoveSelectionIntoFormation(formationTemplate)

binaries/data/mods/public/gui/session/selection_panels_left/barter_panel.xml

@@ -1 +1 @@
 <?xml version="1.0" encoding="utf-8"?>
 <object name="unitBarterPanel" 
-    size="6 36 100% 100%"
+    size="24 12 100% 100%"
     hidden="true"
 >
-    <object ghost="true" style="resourceText" type="text" size="0 0 100% 20">
-        <translatableAttribute id="tooltip">Exchange resources:</translatableAttribute>
-    </object>
-    <object size="0 32 100% 124">
-        <repeat count="4">
-            <!-- sell -->
-            <object name="unitBarterSellButton[n]" style="iconButton" type="button" size="0 0 46 46" tooltip_style="sessionToolTipBottomBold">
-                <object name="unitBarterSellIcon[n]" type="image" ghost="true" size="3 3 43 43"/>
-                <object name="unitBarterSellAmount[n]" ghost="true" style="resourceText" type="text" size="0 0 100% 50%"/>
-                <object name="unitBarterSellSelection[n]" hidden="true" type="image" ghost="true" size="3 3 43 43" sprite="stretched:session/icons/corners.png"/>
-            </object>
-            <!-- buy -->
-            <object name="unitBarterBuyButton[n]" style="iconButton" type="button" size="0 0 46 46" tooltip_style="sessionToolTipBottomBold">
-                <object name="unitBarterBuyIcon[n]" type="image" ghost="true" size="3 3 43 43"/>
-                <object name="unitBarterBuyAmount[n]" ghost="true" style="resourceText" type="text" size="0 0 100% 50%"/>
-            </object>
-        </repeat>
-    </object>
+
+    <repeat count="8">
+
+        <!-- sell -->
+        <object name="unitBarterSellButton[n]" style="iconButton" type="button" size="0 0 36 36" tooltip_style="sessionToolTipBottomBold" hidden="true">
+            <object name="unitBarterSellIcon[n]" type="image" ghost="true" size="3 3 33 33"/>
+            <object name="unitBarterSellAmount[n]" ghost="true" style="resourceText" type="text" size="0 0 100% 50%"/>
+            <object name="unitBarterSellSelection[n]" hidden="true" type="image" ghost="true" size="3 3 33 33" sprite="stretched:session/icons/corners.png"/>
+        </object>
+
+        <!-- buy -->
+        <object name="unitBarterBuyButton[n]" style="iconButton" type="button" size="0 0 36 36" tooltip_style="sessionToolTipBottomBold" hidden="true">
+            <object name="unitBarterBuyIcon[n]" type="image" ghost="true" size="3 3 33 33"/>
+            <object name="unitBarterBuyAmount[n]" ghost="true" style="resourceText" type="text" size="0 0 100% 50%"/>
+        </object>
+
+    </repeat>
+
 </object>

binaries/data/mods/public/gui/session/session.js

@@ -418 +418 @@
         Engine.GetGUIObjectByName("civIcon").sprite = "stretched:" + g_CivData[g_Players[g_ViewedPlayer].civ].Emblem;
         Engine.GetGUIObjectByName("civIconOverlay").tooltip = sprintf(translate("%(civ)s - Structure Tree"), { "civ": civName });
     }
+    
+    let resCodes = GetSimState().resources;
+    let r = 0;
+    for (; r < resCodes.length; ++r)
+    {
+        Engine.GetGUIObjectByName("resource["+r+"]").tooltip = getLocalizedResourceName(resCodes[r], "firstWord");
+        Engine.GetGUIObjectByName("resource["+r+"]_icon").sprite = "stretched:session/icons/resources/" + resCodes[r] + ".png";
+    }
+    horizFitRepeatedObjects ("resource[n]", "n", 0, r);
+    hideRemaining("resource[", r, "]");
 
     // Hide stuff gaia/observers don't use.
-    Engine.GetGUIObjectByName("food").hidden = !isPlayer;
-    Engine.GetGUIObjectByName("wood").hidden = !isPlayer;
-    Engine.GetGUIObjectByName("stone").hidden = !isPlayer;
-    Engine.GetGUIObjectByName("metal").hidden = !isPlayer;
+    for (let r = 0; r < resCodes.length; ++r)
+        Engine.GetGUIObjectByName("resource["+r+"]").hidden = !isPlayer;
     Engine.GetGUIObjectByName("population").hidden = !isPlayer;
     Engine.GetGUIObjectByName("civIcon").hidden = !isPlayer;
     Engine.GetGUIObjectByName("diplomacyButton1").hidden = !isPlayer;
@@ -529 +537 @@
 
     summary.gameResult = gameResult;
     summary.isReplay = g_IsReplay;
+    summary.resources = GetSimState().resources;
     Engine.SwitchGuiPage("page_summary.xml", summary);
 }
 
@@ -920 +929 @@
 
 function updatePlayerDisplay()
 {
-    let playerState = GetSimState().players[g_ViewedPlayer];
+    let simState = GetSimState();
+    let playerState = simState.players[g_ViewedPlayer];
     if (!playerState)
         return;
 
-    Engine.GetGUIObjectByName("resourceFood").caption = Math.floor(playerState.resourceCounts.food);
-    Engine.GetGUIObjectByName("resourceWood").caption = Math.floor(playerState.resourceCounts.wood);
-    Engine.GetGUIObjectByName("resourceStone").caption = Math.floor(playerState.resourceCounts.stone);
-    Engine.GetGUIObjectByName("resourceMetal").caption = Math.floor(playerState.resourceCounts.metal);
+    let resCodes = simState.resources;
+    for (let r = 0; r < resCodes.length; ++r)
+        Engine.GetGUIObjectByName("resource["+r+"]_count").caption = Math.floor(playerState.resourceCounts[resCodes[r]]);
+
     Engine.GetGUIObjectByName("resourcePop").caption = playerState.popCount + "/" + playerState.popLimit;
     Engine.GetGUIObjectByName("population").tooltip = translate("Population (current / limit)") + "\n" +
                     sprintf(translate("Maximum population: %(popCap)s"), { "popCap": playerState.popMax });

binaries/data/mods/public/gui/session/session.xml

@@ -6 +6 @@
 <script file="gui/common/colorFades.js"/>
 <script file="gui/common/functions_civinfo.js"/>
 <script file="gui/common/functions_global_object.js"/>
+<script file="gui/common/functions_repeat_positioning.js"/>
 <script file="gui/common/functions_utility.js"/>
 <script file="gui/common/l10n.js"/>
 <script file="gui/common/music.js"/>

deleted file binaries/data/mods/public/gui/session/top_panel/resource_food.xml

@@ -1 @@
-<?xml version="1.0" encoding="utf-8"?>
-<object name="food" size="10 0 100 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
-        <translatableAttribute id="tooltip">Food</translatableAttribute>
-        <object size="0 -4 40 36" type="image" sprite="stretched:session/icons/resources/food.png" ghost="true"/>
-        <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resourceFood"/>
-</object>

deleted file binaries/data/mods/public/gui/session/top_panel/resource_metal.xml

@@ -1 @@
-<?xml version="1.0" encoding="utf-8"?>
-<object name="metal" size="280 0 370 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
-        <translatableAttribute id="tooltip">Metal</translatableAttribute>
-        <object size="0 -4 40 36" type="image" sprite="stretched:session/icons/resources/metal.png" ghost="true"/>
-        <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resourceMetal"/>
-</object>

binaries/data/mods/public/gui/session/top_panel/resource_population.xml

@@ -1 +1 @@
 <?xml version="1.0" encoding="utf-8"?>
-<object name="population" size="370 0 460 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
+<object name="population" size="50%-90-52 0 50%-52 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
     <object size="0 -4 40 34" type="image" sprite="stretched:session/icons/resources/population.png" ghost="true"/>
     <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resourcePop"/>
 </object>

deleted file binaries/data/mods/public/gui/session/top_panel/resource_stone.xml

@@ -1 @@
-<?xml version="1.0" encoding="utf-8"?>
-<object name="stone" size="190 0 280 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
-        <translatableAttribute id="tooltip">Stone</translatableAttribute>
-        <object size="0 -4 40 36" type="image" sprite="stretched:session/icons/resources/stone.png" ghost="true"/>
-        <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resourceStone"/>
-</object>

deleted file binaries/data/mods/public/gui/session/top_panel/resource_wood.xml

@@ -1 @@
-<?xml version="1.0" encoding="utf-8"?>
-<object name="wood" size="100 0 190 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
-        <translatableAttribute id="tooltip">Wood</translatableAttribute>
-        <object size="0 -4 40 36" type="image" sprite="stretched:session/icons/resources/wood.png" ghost="true"/>
-        <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resourceWood"/>
-</object>

new file inaries/data/mods/public/gui/session/top_panel/resources.xml

@@ +1 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<object size="10 0 50%-90-52 100%">
+  <repeat count="8">
+    <object name="resource[n]" size="0 0 90 100%" type="image" style="resourceCounter" tooltip_style="sessionToolTipBold">
+      <object size="0 -4 40 36" type="image" name="resource[n]_icon" ghost="true"/>
+      <object size="32 0 100% 100%-2" type="text" style="resourceText" name="resource[n]_count"/>
+    </object>
+  </repeat>
+</object>

binaries/data/mods/public/gui/session/trade_window.xml

@@ -16 +16 @@
         </object>
 
         <object size="180 0 100% 100%">
-            <repeat count="4">
+            <repeat count="8">
                 <object name="tradeResource[n]" size="0 0 58 32">
                     <object name="tradeResourceButton[n]" size="4 0 36 100%" type="button" style="StoneButton">
                         <object name="tradeResourceIcon[n]" type="image" ghost="true"/>

binaries/data/mods/public/gui/summary/counters.js

@@ -197 +197 @@
 
 function calculateResources(playerState, position)
 {
-    let type = g_ResourcesTypes[position];
+    let type = g_GameData.resources[position];
 
     return formatIncome(
         playerState.statistics.resourcesGathered[type],
@@ -209 +209 @@
     let totalGathered = 0;
     let totalUsed = 0;
 
-    for (let type of g_ResourcesTypes)
+    for (let type of g_GameData.resources)
     {
         totalGathered += playerState.statistics.resourcesGathered[type];
         totalUsed += playerState.statistics.resourcesUsed[type] - playerState.statistics.resourcesSold[type];
@@ -279 +279 @@
 
 function calculateResourceExchanged(playerState, position)
 {
-    let type = g_ResourcesTypes[position];
+    let type = g_GameData.resources[position];
 
     return formatIncome(
         playerState.statistics.resourcesBought[type],

binaries/data/mods/public/gui/summary/layout.js

@@ -73 +73 @@
     "resources": {
         "headings": [
             { "caption": translate("Player name"), "yStart": 26, "width": 200 },
-            { "caption": translate("Food"), "yStart": 34, "width": 100 },
-            { "caption": translate("Wood"), "yStart": 34, "width": 100 },
-            { "caption": translate("Stone"), "yStart": 34, "width": 100 },
-            { "caption": translate("Metal"), "yStart": 34, "width": 100 },
             { "caption": translate("Total"), "yStart": 34, "width": 110 },
             { "caption": translate("Tributes (Sent / Received)"), "yStart": 16, "width": 121 },
             { "caption": translate("Treasures collected"), "yStart": 16, "width": 100 },
@@ -86 +82 @@
             { "caption": translate("Resource Statistics (Gathered / Used)"), "yStart": 16, "width": (100 * 4 + 110) }, // width = 510
         ],
         "counters": [
-            { "width": 100, "fn": calculateResources },
-            { "width": 100, "fn": calculateResources },
-            { "width": 100, "fn": calculateResources },
-            { "width": 100, "fn": calculateResources },
             { "width": 110, "fn": calculateTotalResources },
             { "width": 121, "fn": calculateTributeSent },
             { "width": 100, "fn": calculateTreasureCollected },
@@ -100 +92 @@
     "market": {
         "headings": [
             { "caption": translate("Player name"), "yStart": 26, "width": 200 },
-            { "caption": translate("Food exchanged"), "yStart": 16, "width": 100 },
-            { "caption": translate("Wood exchanged"), "yStart": 16, "width": 100 },
-            { "caption": translate("Stone exchanged"), "yStart": 16, "width": 100 },
-            { "caption": translate("Metal exchanged"), "yStart": 16, "width": 100 },
             { "caption": translate("Barter efficiency"), "yStart": 16, "width": 100 },
             { "caption": translate("Trade income"), "yStart": 16, "width": 100 }
         ],
         "titleHeadings": [],
         "counters": [
-            { "width": 100, "fn": calculateResourceExchanged },
-            { "width": 100, "fn": calculateResourceExchanged },
-            { "width": 100, "fn": calculateResourceExchanged },
-            { "width": 100, "fn": calculateResourceExchanged },
             { "width": 100, "fn": calculateBarterEfficiency },
             { "width": 100, "fn": calculateTradeIncome }
         ],

binaries/data/mods/public/gui/summary/summary.js

@@ -1 @@
-const g_MaxHeadingTitle= 8;
+const g_MaxHeadingTitle= 12;
 
 // const for filtering long collective headings
 const g_LongHeadingWidth = 250;
@@ -16 +16 @@
 
 const g_BuildingsTypes = [ "total", "House", "Economic", "Outpost", "Military", "Fortress", "CivCentre", "Wonder" ];
 const g_UnitsTypes = [ "total", "Infantry", "Worker", "Cavalry", "Champion", "Hero", "Ship", "Trader" ];
-const g_ResourcesTypes = [ "food", "wood", "stone", "metal" ];
 
 // Colors used for gathered and traded resources
 const g_IncomeColor = '[color="201 255 200"]';
@@ -198 +197 @@
     else
         g_Teams = false;
 
+    // Resource names and counters
+    let resHeads = [];
+    let tradeHeads = [];
+    let resPanel = g_ScorePanelsData.resources;
+    let tradePanel = g_ScorePanelsData.market;
+    for (let code of g_GameData.resources)
+    {
+        resHeads.push({
+                "caption": translateWithContext("firstWord", code),
+                "yStart": 34, "width": 100
+            });
+        resPanel.counters.unshift({"width": 100, "fn": calculateResources});
+        
+        tradeHeads.push({
+                "caption": translate(code+" exchanged"),
+                "yStart": 16, "width": 100,
+            });
+        tradePanel.counters.unshift({"width": 100, "fn": calculateResourceExchanged});
+    }
+    resPanel.headings.splice.apply(resPanel.headings, [1, 0].concat(resHeads));
+    resPanel.titleHeadings[0].width = (100 * g_GameData.resources.length) + 110;
+    tradePanel.headings.splice.apply(tradePanel.headings, [1, 0].concat(tradeHeads));
+
     // Erase teams data if teams are not displayed
     if (!g_Teams)
     {

binaries/data/mods/public/gui/summary/summary.xml

@@ -107 +107 @@
                 <object name="playerNameHeading" type="text" style="ModernLeftTabLabelText">
                     <translatableAttribute id="caption">Player name</translatableAttribute>
                 </object>
-                <repeat var="x" count="8">
+                <repeat var="x" count="12">
                     <object name="titleHeading[x]" type="text" style="ModernTabLabelText">
                     </object>
                 </repeat>
-                <repeat var="x" count="8">
+                <repeat var="x" count="12">
                     <object name="Heading[x]" type="text" style="ModernTabLabelText">
                     </object>
                 </repeat>
@@ -126 +126 @@
                                 <object name="playerColorBoxt[i][n]" type="image" size="10 4 30 24"/>
                                 <object name="playerNamet[i][n]" type="text"  size="40 2 208 100%" style="ModernLeftLabelText" />
                                 <object name="civIcont[i][n]" type="image" size="208 0 240 32"/>
-                                <repeat var="x" count="8">
+                                <repeat var="x" count="12">
                                     <object name="valueDataTeam[i][n][x]" type="text" style="ModernTabLabelText">
                                     </object>
                                 </repeat>
@@ -134 +134 @@
                         </repeat>
                     </object>
                     <object name="teamHeadingt[i]" type="text" style="ModernLeftTabLabelText"/>
-                    <repeat var="x" count="8">
+                    <repeat var="x" count="12">
                         <object name="valueDataTeam[i][x]" type="text" style="ModernTabLabelText">
                         </object>
                     </repeat>
@@ -149 +149 @@
                         </object>
                         <object name="playerName[n]" type="text"  size="40 2 208 100%" style="ModernLeftLabelText"/>
                         <object name="civIcon[n]" type="image" size="208 0 240 32"/>
-                        <repeat var="x" count="8">
+                        <repeat var="x" count="12">
                             <object name="valueData[n][x]" type="text" style="ModernTabLabelText">
                             </object>
                         </repeat>

binaries/data/mods/public/simulation/ai/common-api/resources.js

@@ -9 +9 @@
     this.population = population > 0 ? population : 0;
 };
 
-m.Resources.prototype.types = [ "food", "wood", "stone", "metal" ];
+m.Resources.prototype.types = [ ]; // Gets populated in SharedScript.init
 
 m.Resources.prototype.reset = function()
 {

binaries/data/mods/public/simulation/ai/common-api/shared.js

@@ -27 +27 @@
 
     // A few notes about these maps. They're updated by checking for "create" and "destroy" events for all resources
     // TODO: change the map when the resource amounts change for at least stone and metal mines.
-    this.resourceMaps = {}; // Contains maps showing the density of wood, stone and metal
-    this.CCResourceMaps = {}; // Contains maps showing the density of wood, stone and metal, optimized for CC placement.
+    this.resourceMaps = {}; // Contains maps showing the density of resources
+    this.CCResourceMaps = {}; // Contains maps showing the density of resources, optimized for CC placement.
     // Resource maps data.
-    // By how much to divide the resource amount when filling the map (ie a tree having 200 wood is "4").
-    this.decreaseFactor = {"wood": 50.0, "stone": 90.0, "metal": 90.0};
+    this.decreaseFactor = {};
+    this.influenceMapGroup = {};
 };
 
 //Return a simple object (using no classes etc) that will be serialized into saved games
@@ -142 +142 @@
     this.mapSize = state.mapSize;
     this.gameType = state.gameType;
     this.barterPrices = state.barterPrices;
+    
+    m.Resources.prototype.types = state.resources;
 
     this.passabilityMap = state.passabilityMap;
     if (this.mapSize % this.passabilityMap.width !== 0)
@@ -179 +181 @@
     this.accessibility = new m.Accessibility();
     this.accessibility.init(state, this.terrainAnalyzer);
     
-    // defined in TerrainAnalysis.js
+    // By how much to divide the resource amount when filling the map (ie a tree having 200 wood is "4").
+    for (let res in state.aiResourceAnalysis)
+    {
+        if (!state.aiResourceAnalysis[res])
+            continue;
+        this.decreaseFactor[res] = state.aiResourceAnalysis[res].decreaseFactor;
+        this.influenceMapGroup[res] = state.aiResourceAnalysis[res].influenceMapGroup;
+    }
+    // defined in terrain-analysis.js
     this.createResourceMaps(this);
 
     this.gameState = {};

binaries/data/mods/public/simulation/ai/common-api/terrain-analysis.js

@@ -382 +382 @@
 
 // creates a map of resource density
 m.SharedScript.prototype.createResourceMaps = function(sharedScript)
-{   
+{
     for (let resource in this.decreaseFactor)
     {
         // if there is no resourceMap create one with an influence for everything with that resource
@@ -394 +394 @@
             this.CCResourceMaps[resource] = new m.Map(sharedScript, "resource");
         }
     }
-    let cellSize = this.resourceMaps.wood.cellSize;
+
     for (let ent of sharedScript._entities.values())
     {
         if (ent && ent.position() && ent.resourceSupplyType() && ent.resourceSupplyType().generic !== "treasure") {
             let resource = ent.resourceSupplyType().generic;
             if (!this.resourceMaps[resource])
                 continue;
+
+            let cellSize = this.resourceMaps[resource].cellSize;
             let x = Math.floor(ent.position()[0] / cellSize);
             let z = Math.floor(ent.position()[1] / cellSize);
             let strength = Math.floor(ent.resourceSupplyMax()/this.decreaseFactor[resource]);
-            if (resource === "wood")
+            if (this.influenceMapGroup[resource] === 0)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 60/cellSize, strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, strength/2, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, strength/2);
             }
-            else if (resource === "stone" || resource === "metal")
+            else if (this.influenceMapGroup[resource] === 1)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 120/cellSize, strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 48/cellSize, strength/2, "constant");
@@ -438 +440 @@
             this.CCResourceMaps[resource] = new m.Map(sharedScript, "resource");
         }
     }
-    let cellSize = this.resourceMaps.wood.cellSize;
+
     // Look for destroy events and subtract the entities original influence from the resourceMap
     // TODO: perhaps do something when dropsites appear/disappear.
     let destEvents = events.Destroy;
@@ -454 +456 @@
             let resource = ent.resourceSupplyType().generic;
             if (!this.resourceMaps[resource])
                 continue;
+
+            let cellSize = this.resourceMaps[resource].cellSize;
             let x = Math.floor(ent.position()[0] / cellSize);
             let z = Math.floor(ent.position()[1] / cellSize);
             let strength = Math.floor(ent.resourceSupplyMax()/this.decreaseFactor[resource]);
-            if (resource === "wood")
+            if (this.influenceMapGroup[resource] === 0)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 60/cellSize, -strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, -strength/2, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, -strength/2);
             }
-            else if (resource === "stone" || resource === "metal")
+            else if (this.influenceMapGroup[resource] === 1)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 120/cellSize, -strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 48/cellSize, -strength/2, "constant");
@@ -481 +485 @@
             let resource = ent.resourceSupplyType().generic;
             if (!this.resourceMaps[resource])
                 continue;
+
+            let cellSize = this.resourceMaps[resource].cellSize;
             let x = Math.floor(ent.position()[0] / cellSize);
             let z = Math.floor(ent.position()[1] / cellSize);
             let strength = Math.floor(ent.resourceSupplyMax()/this.decreaseFactor[resource]);
-            if (resource === "wood")
+            if (this.influenceMapGroup[resource] === 0)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 60/cellSize, strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, strength/2, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 36/cellSize, strength/2);
             }
-            else if (resource === "stone" || resource === "metal")
+            else if (this.influenceMapGroup[resource] === 1)
             {
                 this.CCResourceMaps[resource].addInfluence(x, z, 120/cellSize, strength, "constant");
                 this.resourceMaps[resource].addInfluence(x, z, 48/cellSize, strength/2, "constant");

binaries/data/mods/public/simulation/components/Barter.js

@@ -1 @@
-// True price of 100 units of resource (for case if some resource is more worth).
+// The "true price" is a base price of 100 units of resource (for the case of some resources being of more worth than others).
 // With current bartering system only relative values makes sense
 // so if for example stone is two times more expensive than wood,
 // there will 2:1 exchange rate.
-const TRUE_PRICES = { "food": 100, "wood": 100, "stone": 100, "metal": 100 };
-
+//
 // Constant part of price difference between true price and buy/sell price.
 // In percents.
 // Buy price equal to true price plus constant difference.
@@ -21 +20 @@
 // Interval of timer which slowly restore prices after deals
 const RESTORE_TIMER_INTERVAL = 5000;
 
-// Array of resource names
-const RESOURCES = ["food", "wood", "stone", "metal"];
-
 function Barter() {}
 
 Barter.prototype.Schema =
@@ -32 +28 @@
 Barter.prototype.Init = function()
 {
     this.priceDifferences = {};
-    for (var resource of RESOURCES)
+    for (let resource of Resources.GetCodes())
         this.priceDifferences[resource] = 0;
     this.restoreTimer = undefined;
 };
@@ -40 +36 @@
 Barter.prototype.GetPrices = function()
 {
     var prices = { "buy": {}, "sell": {} };
-    for (var resource of RESOURCES)
+    for (let resource of Resources.GetCodes())
     {
-        prices["buy"][resource] = TRUE_PRICES[resource] * (100 + CONSTANT_DIFFERENCE + this.priceDifferences[resource]) / 100;
-        prices["sell"][resource] = TRUE_PRICES[resource] * (100 - CONSTANT_DIFFERENCE + this.priceDifferences[resource]) / 100;
+        let truePrice = Resources.GetResource(resource).truePrice;
+        prices.buy[resource] = truePrice * (100 + CONSTANT_DIFFERENCE + this.priceDifferences[resource]) / 100;
+        prices.sell[resource] = truePrice * (100 - CONSTANT_DIFFERENCE + this.priceDifferences[resource]) / 100;
     }
     return prices;
 };
@@ -71 +68 @@
         warn("ExchangeResources: incorrect amount: " + uneval(amount));
         return;
     }
-    if (RESOURCES.indexOf(resourceToSell) == -1)
+    let availResources = Resources.GetCodes();
+    if (availResources.indexOf(resourceToSell) == -1)
     {
         warn("ExchangeResources: incorrect resource to sell: " + uneval(resourceToSell));
         return;
     }
-    if (RESOURCES.indexOf(resourceToBuy) == -1)
+    if (availResources.indexOf(resourceToBuy) == -1)
     {
         warn("ExchangeResources: incorrect resource to buy: " + uneval(resourceToBuy));
         return;
@@ -123 +121 @@
 Barter.prototype.ProgressTimeout = function(data)
 {
     var needRestore = false;
-    for (var resource of RESOURCES)
+    for (let resource of Resources.GetCodes())
     {
         // Calculate value to restore, it should be limited to [-DIFFERENCE_RESTORE; DIFFERENCE_RESTORE] interval
         var differenceRestore = Math.min(DIFFERENCE_RESTORE, Math.max(-DIFFERENCE_RESTORE, this.priceDifferences[resource]));

binaries/data/mods/public/simulation/components/Cost.js

@@ -19 +19 @@
     "<element name='PopulationBonus' a:help='Population cap increase while this entity exists'>" +
         "<data type='nonNegativeInteger'/>" +
     "</element>" +
-    "<element name='BuildTime' a:help='Time taken to construct/train this unit (in seconds)'>" +
+    "<element name='BuildTime' a:help='Time taken to construct/train this entity (in seconds)'>" +
         "<ref name='nonNegativeDecimal'/>" +
     "</element>" +
-    "<element name='Resources' a:help='Resource costs to construct/train this unit'>" +
+    "<element name='Resources' a:help='Resource costs to construct/train this entity'>" +
         "<interleave>" +
-            "<element name='food'><data type='nonNegativeInteger'/></element>" +
-            "<element name='wood'><data type='nonNegativeInteger'/></element>" +
-            "<element name='stone'><data type='nonNegativeInteger'/></element>" +
-            "<element name='metal'><data type='nonNegativeInteger'/></element>" +
+            "<oneOrMore>" +
+                "<element a:help='A particular resource cost'>" +
+                    "<anyName/>" +
+                    "<data type='nonNegativeInteger'/>" +
+                "</element>" +
+            "</oneOrMore>" +
         "</interleave>" +
     "</element>";
 
@@ -70 +72 @@
     let entityTemplate = cmpTemplateManager.GetTemplate(entityTemplateName);
 
     let costs = {};
+    let resCodes = Resources.GetCodes();
+
     for (let r in this.template.Resources)
-        costs[r] = ApplyValueModificationsToTemplate("Cost/Resources/"+r, +this.template.Resources[r], owner, entityTemplate);
+    {
+        let cost = +this.template.Resources[r];
+        if (resCodes.indexOf(r.toLowerCase()) < 0)
+        {
+            if (cost > 0)
+                warn("'"+r+"' has been specified as a required resource, but is not a valid resource.");
+            continue;
+        }
+        costs[r] = ApplyValueModificationsToTemplate("Cost/Resources/"+r, cost, owner, entityTemplate);
+    }
+
     return costs;
 };
 

binaries/data/mods/public/simulation/components/GuiInterface.js

@@ -151 +151 @@
     let cmpBarter = Engine.QueryInterface(SYSTEM_ENTITY, IID_Barter);
     ret.barterPrices = cmpBarter.GetPrices();
 
+    // Add Resource Codes
+    ret.resources = Resources.GetCodes();
+    ret.aiResourceAnalysis = {};
+    for (let res of ret.resources)
+        ret.aiResourceAnalysis[res] = Resources.GetResource(res).aiAnalysis || null;
+
     // Add basic statistics to each player
     for (let i = 0; i < numPlayers; ++i)
     {
@@ -1246 +1252 @@
 
     let result = {
         "pieces": [],
-        "cost": { "food": 0, "wood": 0, "stone": 0, "metal": 0, "population": 0, "populationBonus": 0, "time": 0 },
+        "cost": {"population": 0, "populationBonus": 0, "time": 0},
     };
-
+    for (let res of Resources.GetCodes())
+        result.cost[res] = 0;
+    
     let previewEntities = [];
     if (end.pos)
         previewEntities = GetWallPlacement(this.placementWallEntities, wallSet, start, end); // see helpers/Walls.js
@@ -1522 +1530 @@
             // copied over, so we need to fetch it from the template instead).
             // TODO: we should really use a Cost object or at least some utility functions for this, this is mindless
             // boilerplate that's probably duplicated in tons of places.
-            result.cost.food += tplData.cost.food;
-            result.cost.wood += tplData.cost.wood;
-            result.cost.stone += tplData.cost.stone;
-            result.cost.metal += tplData.cost.metal;
-            result.cost.population += tplData.cost.population;
-            result.cost.populationBonus += tplData.cost.populationBonus;
-            result.cost.time += tplData.cost.time;
+            let entries = Resources.GetCodes().concat("population", "populationBonus", "time");
+            for (let res of entries)
+                result.cost[res] = tplData.cost[res];
         }
 
         let canAfford = true;

binaries/data/mods/public/simulation/components/Loot.js

@@ -1 +1 @@
 function Loot() {}
 
 Loot.prototype.Schema =
-    "<optional>" +
-        "<element name='xp'><data type='nonNegativeInteger'/></element>" +
-    "</optional>" +
-    "<optional>" +
-        "<element name='food'><data type='nonNegativeInteger'/></element>" +
-    "</optional>" +
-    "<optional>" +
-        "<element name='wood'><data type='nonNegativeInteger'/></element>" +
-    "</optional>" +
-    "<optional>" +
-        "<element name='stone'><data type='nonNegativeInteger'/></element>" +
-    "</optional>" +
-    "<optional>" +
-        "<element name='metal'><data type='nonNegativeInteger'/></element>" +
-    "</optional>";
+    "<a:help>Specifies the loot credited when this entity is killed.</a:help>" +
+    "<a:example>" +
+        "<xp>35</xp>" +
+        "<metal>10</metal>" +
+    "</a:example>" +
+    "<oneOrMore>" +
+        "<element a:help='A resource or xp amount to be credited'>" +
+            "<anyName/>" +
+            "<data type='nonNegativeInteger'/>" +
+        "</element>" +
+    "</oneOrMore>";
 
 Loot.prototype.Serialize = null; // we have no dynamic state to save
 
@@ -26 +22 @@
 
 Loot.prototype.GetResources = function()
 {
-    return {
-        "food": +(this.template.food || 0),
-        "wood": +(this.template.wood || 0),
-        "metal": +(this.template.metal || 0),
-        "stone": +(this.template.stone || 0)
-    };
+    var ret = {};
+    for (let res of Resources.GetCodes())
+        ret[res] = +(this.template[res] || 0);
+    
+    return ret;
 };
 
 Engine.RegisterComponentType(IID_Loot, "Loot", Loot);

binaries/data/mods/public/simulation/components/Player.js

@@ -18 +18 @@
     this.popBonuses = 0; // sum of population bonuses of player's entities
     this.maxPop = 300; // maximum population
     this.trainingBlocked = false; // indicates whether any training queue is currently blocked
-    this.resourceCount = {
-        "food": 300,
-        "wood": 300,
-        "metal": 300,
-        "stone": 300
-    };
-    // goods for next trade-route and its proba in % (the sum of probas must be 100)
-    this.tradingGoods = [
-        { "goods":  "wood", "proba": 30 },
-        { "goods": "stone", "proba": 35 },
-        { "goods": "metal", "proba": 35 },
-    ];
+    this.resourceCount = {};
+    this.tradingGoods = []; // goods for next trade-route and its proba in % (the sum of probas must be 100)
     this.team = -1; // team number of the player, players on the same team will always have ally diplomatic status - also this is useful for team emblems, scoring, etc.
     this.teamsLocked = false;
     this.state = "active"; // game state - one of "active", "defeated", "won"
@@ -44 +34 @@
     this.cheatsEnabled = false;
     this.cheatTimeMultiplier = 1;
     this.heroes = [];
-    this.resourceNames = {
-        "food": markForTranslation("Food"),
-        "wood": markForTranslation("Wood"),
-        "metal": markForTranslation("Metal"),
-        "stone": markForTranslation("Stone"),
-    };
+    this.resourceNames = {};
     this.disabledTemplates = {};
     this.disabledTechnologies = {};
     this.startingTechnologies = [];
+    
+    var resCodes = Resources.GetCodes();
+    var tradeProportions = [ 0, 0 ];
+    tradeProportions[0] = Math.floor(20 / resCodes.length);
+    tradeProportions[1] = 20 - resCodes.length * tradeProportions[0];
+    var resPos = 0;
+    for (let res of resCodes)
+    {
+        this.resourceCount[res] = 300;
+        this.resourceNames[res] = Resources.GetResource(res).name;
+        let proportion = tradeProportions[0] + ((resPos < tradeProportions[1]) ? 1 : 0);
+        this.tradingGoods.push({ "goods":  res, "proba": (proportion * 5) });
+        resPos++;
+    }
 };
 
 Player.prototype.SetPlayerID = function(id)
@@ -197 +196 @@
 
 Player.prototype.SetResourceCounts = function(resources)
 {
-    if (resources.food !== undefined)
-        this.resourceCount.food = resources.food;
-    if (resources.wood !== undefined)
-        this.resourceCount.wood = resources.wood;
-    if (resources.stone !== undefined)
-        this.resourceCount.stone = resources.stone;
-    if (resources.metal !== undefined)
-        this.resourceCount.metal = resources.metal;
+    for (let res in resources)
+    {
+        if (this.resourceCount[res] === undefined)
+            warn("The "+res+" resourcehas been passed to cmpPlayer, but does not exist/has been disabled by mod");
+        this.resourceCount[res] = resources[res];
+    }
 };
 
 Player.prototype.GetResourceCounts = function()
@@ -297 +294 @@
 
     // Subtract the resources
     for (var type in amounts)
-        this.resourceCount[type] -= amounts[type];
+        if (this.resourceCount[type])
+            this.resourceCount[type] -= amounts[type];
 
     return true;
 };
@@ -346 +344 @@
     if (sumProba != 100)    // consistency check
     {
         error("Player.js SetTradingGoods: " + uneval(tradingGoods));
-        tradingGoods = { "food": 20, "wood":20, "stone":30, "metal":30 };
+        var first = true;
+        for (let res of Resources.GetCodes())
+            if (first)
+            {
+                tradingGoods[res] = 100;
+                first = false;
+            }
+            else
+                tradingGoods[res] = 0;
     }
 
     this.tradingGoods = [];

binaries/data/mods/public/simulation/components/ProductionQueue.js

@@ -261 +261 @@
     // TODO: there should be a way for the GUI to determine whether it's going
     // to be possible to add a batch (based on resource costs and length limits)
     var cmpPlayer = QueryOwnerInterface(this.entity);
+    var resCodes = Resources.GetCodes();
 
     if (this.queue.length < MAX_QUEUE_SIZE)
     {
@@ -295 +296 @@
 
             for (var r in template.Cost.Resources)
             {
-                costs[r] = ApplyValueModificationsToTemplate("Cost/Resources/"+r, +template.Cost.Resources[r], cmpPlayer.GetPlayerID(), template);
+                let cost = +template.Cost.Resources[r];
+                if (resCodes.indexOf(r) < 0)
+                {
+                    if (cost > 0)
+                        warn("'"+r+"' has been specified as a required resource, but is not a valid resource.");
+                    continue;
+                }
+                costs[r] = ApplyValueModificationsToTemplate("Cost/Resources/"+r, cost, cmpPlayer.GetPlayerID(), template);
                 totalCosts[r] = Math.floor(count * costs[r]);
             }
 
@@ -342 +350 @@
             let time =  techCostMultiplier.time * template.researchTime * cmpPlayer.GetCheatTimeMultiplier();
 
             var cost = {};
-            for (let res in template.cost)
-                cost[res] = Math.floor(techCostMultiplier[res] * template.cost[res]);
+            for (let r in template.cost)
+            {
+                if (resCodes.indexOf(r) < 0)
+                {
+                    if (Math.floor(template.cost[r]) > 0)
+                        warn("'"+r+"' has been specified as a required resource, but is not a valid resource.");
+                    continue;
+                }
+                cost[r] = Math.floor((techCostMultiplier[r] ? techCostMultiplier[r] : 1) * template.cost[r]);;
+            }
 
             // TrySubtractResources should report error to player (they ran out of resources)
             if (!cmpPlayer.TrySubtractResources(cost))
@@ -361 +377 @@
                 "player": cmpPlayer.GetPlayerID(),
                 "count": 1,
                 "technologyTemplate": templateName,
-                "resources": deepcopy(template.cost), // need to copy to avoid serialization problems
+                "resources": cost,
                 "productionStarted": false,
                 "timeTotal": time*1000,
                 "timeRemaining": time*1000,
@@ -433 +449 @@
         // Refund the resource cost for this batch
         var totalCosts = {};
         var cmpStatisticsTracker = QueryPlayerIDInterface(item.player, IID_StatisticsTracker);
-        for each (var r in ["food", "wood", "stone", "metal"])
+        for (let r of Resources.GetCodes())
         {
+            if (!item.resources[r])
+                continue;
             totalCosts[r] = Math.floor(item.count * item.resources[r]);
             if (cmpStatisticsTracker)
                 cmpStatisticsTracker.IncreaseResourceUsedCounter(r, -totalCosts[r]);

binaries/data/mods/public/simulation/components/ResourceDropsite.js

@@ -2 +2 @@
 
 ResourceDropsite.prototype.Schema =
     "<element name='Types'>" +
-        "<list>" +
-            "<zeroOrMore>" +
-                "<choice>" +
-                    "<value>food</value>" +
-                    "<value>wood</value>" +
-                    "<value>stone</value>" +
-                    "<value>metal</value>" +
-                "</choice>" +
-            "</zeroOrMore>" +
-        "</list>" +
+        "<text/>" +
     "</element>" +
     "<element name='Sharable' a:help='Allows allies to use this entity.'>" +
         "<data type='boolean'/>" +
@@ -28 +19 @@
  */
 ResourceDropsite.prototype.GetTypes = function()
 {
-    let types = ApplyValueModificationsToEntity("ResourceDropsite/Types", this.template.Types, this.entity);
-    return types ? types.split(/\s+/) : [];
+    let typesTok = ApplyValueModificationsToEntity("ResourceDropsite/Types", this.template.Types, this.entity);
+    let typesArr = [];
+    let resources = Resources.GetCodes();
+
+    for (let type of typesTok.split(/\s+/))
+        if (resources.indexOf(type.toLowerCase()) > -1)
+            typesArr.push(type);
+
+    return typesArr;
 };
 
 /**

binaries/data/mods/public/simulation/components/ResourceGatherer.js

@@ -26 +26 @@
     "</element>" +
     "<element name='Rates' a:help='Per-resource-type gather rate multipliers. If a resource type is not specified then it cannot be gathered by this unit'>" +
         "<interleave>" +
-            "<optional><element name='food' a:help='Food gather rate (may be overridden by \"food.*\" subtypes)'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='wood' a:help='Wood gather rate'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='stone' a:help='Stone gather rate'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='metal' a:help='Metal gather rate'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='treasure' a:help='Treasure gather rate (only presense on value makes sense, size is only used to determine the delay before gathering, so it should be set to 1)'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='food.fish' a:help='Fish gather rate (overrides \"food\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='food.fruit' a:help='Fruit gather rate (overrides \"food\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='food.grain' a:help='Grain gather rate (overrides \"food\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='food.meat' a:help='Meat gather rate (overrides \"food\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='food.milk' a:help='Milk gather rate (overrides \"food\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='wood.tree' a:help='Tree gather rate (overrides \"wood\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='wood.ruins' a:help='Tree gather rate (overrides \"wood\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='stone.rock' a:help='Rock gather rate (overrides \"stone\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='stone.ruins' a:help='Rock gather rate (overrides \"stone\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='metal.ore' a:help='Ore gather rate (overrides \"metal\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='treasure.food' a:help='Food treasure gather rate (overrides \"treasure\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='treasure.wood' a:help='Wood treasure gather rate (overrides \"treasure\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='treasure.stone' a:help='Stone treasure gather rate (overrides \"treasure\")'><ref name='positiveDecimal'/></element></optional>" +
-            "<optional><element name='treasure.metal' a:help='Metal treasure gather rate (overrides \"treasure\")'><ref name='positiveDecimal'/></element></optional>" +
+            "<oneOrMore>" +
+                "<element a:help='A particular gather rate, with the element name in the form {type} or {type}.{subtype}'>" +
+                    "<anyName/>" +
+                    "<ref name='positiveDecimal'/>" +
+                "</element>" +
+            "</oneOrMore>" +
         "</interleave>" +
     "</element>" +
     "<element name='Capacities' a:help='Per-resource-type maximum carrying capacity'>" +
         "<interleave>" +
-            "<element name='food' a:help='Food capacity'><ref name='positiveDecimal'/></element>" +
-            "<element name='wood' a:help='Wood capacity'><ref name='positiveDecimal'/></element>" +
-            "<element name='stone' a:help='Stone capacity'><ref name='positiveDecimal'/></element>" +
-            "<element name='metal' a:help='Metal capacity'><ref name='positiveDecimal'/></element>" +
+            "<oneOrMore>" +
+                "<element a:help='A particular resource capacity'>" +
+                    "<anyName/>" +
+                    "<ref name='positiveDecimal'/>" +
+                "</element>" +
+            "</oneOrMore>" +
         "</interleave>" +
     "</element>";
 
@@ -137 +126 @@
     this.rates = {};
     for (let r in this.template.Rates)
     {
+        let type = r.split(".");
+        let res = Resources.GetResource(type[0]);
+        
+        if (!res && type[0] !== "treasure" || (type.length > 1 && res.subtypes.indexOf(type[1]) < 0))
+            continue;
+        
         let rate = ApplyValueModificationsToEntity("ResourceGatherer/Rates/" + r, +this.template.Rates[r], this.entity);
         this.rates[r] = rate * this.baseSpeed;
     }
@@ -174 +169 @@
 
 /**
  * Try to gather treasure
- * @return 'true' if treasure is successfully gathered and 'false' in the other case
+ * @return 'true' if treasure is successfully gathered and 'false' if not
  */
 ResourceGatherer.prototype.TryInstantGather = function(target)
 {

binaries/data/mods/public/simulation/components/ResourceSupply.js

@@ -12 +12 @@
     "<element name='Amount' a:help='Amount of resources available from this entity'>" +
         "<choice><data type='nonNegativeInteger'/><value>Infinity</value></choice>" +
     "</element>" +
-    "<element name='Type' a:help='Type of resources'>" +
-        "<choice>" +
-            "<value>wood.tree</value>" +
-            "<value>wood.ruins</value>" +
-            "<value>stone.rock</value>" +
-            "<value>stone.ruins</value>" +
-            "<value>metal.ore</value>" +
-            "<value>food.fish</value>" +
-            "<value>food.fruit</value>" +
-            "<value>food.grain</value>" +
-            "<value>food.meat</value>" +
-            "<value>food.milk</value>" +
-            "<value>treasure.wood</value>" +
-            "<value>treasure.stone</value>" +
-            "<value>treasure.metal</value>" +
-            "<value>treasure.food</value>" +
-        "</choice>" +
+    "<element name='Type' a:help='Type and Subtype of resource available from this entity, in the form of {type}.{subtype}'>" +
+        "<text/>" +
     "</element>" +
     "<element name='MaxGatherers' a:help='Amount of gatherers who can gather resources from this entity at the same time'>" +
         "<data type='nonNegativeInteger'/>" +
@@ -52 +37 @@
 
     this.infinite = !isFinite(+this.template.Amount);
 
-    [this.type,this.subType] = this.template.Type.split('.');
-    this.cachedType = { "generic" : this.type, "specific" : this.subType };
+    [this.type, this.subtype] = this.template.Type.split('.');
+    var resData = Resources.GetResource(this.type);
+    if (this.type === "treasure")
+        resData = { "subtypes": Resources.GetCodes() };
 
+    if (!resData || resData.subtypes.indexOf(this.subtype) === -1)
+    {
+        // Display Error and Remove entity if the resource supplied is not valid.
+        error("Invalid resource type or subtype ("+this.type+"/"+this.subtype+")");
+        Engine.DestroyEntity(this.entity);
+    }
+    this.cachedType = { "generic" : this.type, "specific" : this.subtype };
 };
 
 ResourceSupply.prototype.IsInfinite = function()

binaries/data/mods/public/simulation/components/ResourceTrickle.js

@@ -3 +3 @@
 ResourceTrickle.prototype.Schema = 
     "<a:help>Controls the resource trickle ability of the unit.</a:help>" +
     "<element name='Rates' a:help='Trickle Rates'>" +
-        "<interleave>" +
-            "<optional>" +
-                "<element name='food' a:help='Food given to the player every interval'>" +
-                    "<ref name='nonNegativeDecimal'/>" +
-                "</element>" +
-            "</optional>" +
-            "<optional>" +
-                "<element name='wood' a:help='Wood given to the player every interval'>" +
-                    "<ref name='nonNegativeDecimal'/>" +
-                "</element>" +
-            "</optional>" +
-            "<optional>" +
-                "<element name='stone' a:help='Stone given to the player every interval'>" +
-                    "<ref name='nonNegativeDecimal'/>" +
-                "</element>" +
-            "</optional>" +
-            "<optional>" +
-                "<element name='metal' a:help='Metal given to the player every interval'>" +
-                    "<ref name='nonNegativeDecimal'/>" +
-                "</element>" +
-            "</optional>" +
-        "</interleave>" +
+        "<oneOrMore>" +
+            "<element a:help='Quantity of a Resource given to the player every interval'>" +
+                "<anyName/>" +
+                "<ref name='nonNegativeDecimal'/>" +
+            "</element>" +
+        "</oneOrMore>" +
     "</element>" +
     "<element name='Interval' a:help='Number of miliseconds must pass for the player to gain the next trickle.'>" +
         "<ref name='nonNegativeDecimal'/>" +
@@ -46 +30 @@
 ResourceTrickle.prototype.GetRates = function()
 {
     var rates = {};
+    var resCodes = Resources.GetCodes();
     for (var resource in this.template.Rates)
+    {
+        if (resCodes.indexOf(resource) < 0)
+            continue;
         rates[resource] = ApplyValueModificationsToEntity("ResourceTrickle/Rates/"+resource, +this.template.Rates[resource], this.entity);
+    }
 
     return rates;
 };
@@ -55 +44 @@
 // Do the actual work here
 ResourceTrickle.prototype.Trickle = function(data, lateness)
 {
-    var cmpPlayer = QueryOwnerInterface(this.entity);
-    if (!cmpPlayer)
-        return;
-
-    var rates = this.GetRates();
-    for (var resource in rates)
-        cmpPlayer.AddResource(resource, rates[resource]);
+    var cmpPlayer = QueryOwnerInterface(this.entity, IID_Player);
+    if (cmpPlayer)
+        cmpPlayer.AddResources(this.GetRates());
 };
 
 Engine.RegisterComponentType(IID_ResourceTrickle, "ResourceTrickle", ResourceTrickle);

binaries/data/mods/public/simulation/components/StatisticsTracker.js

@@ -94 +94 @@
     this.enemyBuildingsDestroyedValue = 0;
 
     this.resourcesGathered = {
-        "food": 0,
-        "wood": 0,
-        "metal": 0,
-        "stone": 0,
         "vegetarianFood": 0
     };
-    this.resourcesUsed = {
-        "food": 0,
-        "wood": 0,
-        "metal": 0,
-        "stone": 0
-    };
-    this.resourcesSold = {
-        "food": 0,
-        "wood": 0,
-        "metal": 0,
-        "stone": 0
-    };
-    this.resourcesBought = {
-        "food": 0,
-        "wood": 0,
-        "metal": 0,
-        "stone": 0
-    };
+    this.resourcesUsed = {};
+    this.resourcesSold = {};
+    this.resourcesBought = {};
+    for (let res of Resources.GetCodes())
+    {
+        this.resourcesGathered[res] = 0;
+        this.resourcesUsed[res] = 0;
+        this.resourcesSold[res] = 0;
+        this.resourcesBought[res] = 0;
+    }
 
     this.tributesSent = 0;
     this.tributesReceived = 0;
@@ -314 +302 @@
  */
 StatisticsTracker.prototype.IncreaseResourceUsedCounter = function(type, amount)
 {
-    this.resourcesUsed[type] += amount;
+    if (typeof this.resourcesUsed[type] === "number")
+        this.resourcesUsed[type] += amount;
 };
 
 StatisticsTracker.prototype.IncreaseTreasuresCollectedCounter = function()

binaries/data/mods/public/simulation/components/Trader.js

@@ -4 +4 @@
 // Additional gain for ships for each garrisoned trader, in percents
 const GARRISONED_TRADER_ADDITION = 20;
 
-// Array of resource names
-const RESOURCES = ["food", "wood", "stone", "metal"];
-
 function Trader() {}
 
 Trader.prototype.Schema =
@@ -149 +146 @@
 Trader.prototype.SetRequiredGoods = function(requiredGoods)
 {
     // Check that argument is a correct resource name
-    if (!requiredGoods || RESOURCES.indexOf(requiredGoods) == -1)
+    if (!requiredGoods || Resources.GetCodes().indexOf(requiredGoods) == -1)
         this.requiredGoods = undefined;
     else
         this.requiredGoods = requiredGoods;
@@ -230 +227 @@
     // if still nothing (but should never happen), choose metal
     // and recomputes the gain in case it has changed (for example by technology)
     var nextGoods = this.GetRequiredGoods();
-    if (!nextGoods || RESOURCES.indexOf(nextGoods) == -1)
+    var resCodes = Resources.GetCodes();
+    if (!nextGoods || resCodes.indexOf(nextGoods) == -1)
     {
         let cmpPlayer = QueryOwnerInterface(this.entity);
         if (cmpPlayer)
             nextGoods = cmpPlayer.GetNextTradingGoods();
 
-        if (!nextGoods || RESOURCES.indexOf(nextGoods) == -1)
+        if (!nextGoods || resCodes.indexOf(nextGoods) == -1)
             nextGoods = "metal";
     }
     this.goods.type = nextGoods;

new file inaries/data/mods/public/simulation/data/resources/food.json

@@ +1 @@
+{
+    "code": "food",
+    "subtypes": [
+        "fish",
+        "fruit",
+        "grain",
+        "meat",
+        "milk"
+    ],
+    "truePrice": 100
+}

new file inaries/data/mods/public/simulation/data/resources/metal.json

@@ +1 @@
+{
+    "code": "metal",
+    "subtypes": [
+        "ore"
+    ],
+    "truePrice": 100,
+    "aiAnalysis": {
+        "decreaseFactor": 90.0,
+        "influenceMapGroup": 1
+    }
+}

new file inaries/data/mods/public/simulation/data/resources/stone.json

@@ +1 @@
+{
+    "code": "stone",
+    "subtypes": [
+        "rock",
+        "ruins"
+    ],
+    "truePrice": 100,
+    "aiAnalysis": {
+        "decreaseFactor": 90.0,
+        "influenceMapGroup": 1
+    }
+}

new file inaries/data/mods/public/simulation/data/resources/wood.json

@@ +1 @@
+{
+    "code": "wood",
+    "subtypes": [
+        "tree",
+        "ruins"
+    ],
+    "truePrice": 100,
+    "aiAnalysis": {
+        "decreaseFactor": 50.0,
+        "influenceMapGroup": 0
+    }
+}

new file inaries/data/mods/public/simulation/helpers/Resources.js

@@ +1 @@
+/**
+ * Resource handling helper script
+ *
+ */
+
+var Resources = {};
+
+/**
+ * Returns an object containing all readable resource data
+ */
+Resources.LoadData = function()
+{
+    this.resourceData = {};
+    var jsonFiles = Engine.FindJSONFiles("resources", false);
+    
+    for (let filename of jsonFiles)
+    {
+        let data = Engine.ReadJSONFile("resources/"+filename+".json");
+        if (!data)
+            continue;
+
+        this.resourceData[data.code] = data;
+    }
+    return this.resourceData;
+};
+
+Resources.GetAllData = function()
+{
+    if (!this.resourceData)
+        return this.LoadData();
+    else
+        return this.resourceData;
+};
+
+Resources.GetResource = function(type)
+{
+    var data = this.GetAllData();
+    type = type.toLowerCase();
+    
+    return data[type] || false;
+};
+
+/**
+ * Returns an array of codes belonging to the resources
+ */
+Resources.GetCodes = function()
+{
+    return Object.keys(this.GetAllData());
+};
+
+Engine.RegisterGlobal("Resources", Resources);