Changes between Initial Version and Version 1 of Ticket #1318, comment 19


Ignore:
Timestamp:
Jun 29, 2013, 3:37:09 AM (11 years ago)
Author:
historic_bruno

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1318, comment 19

    initial v1  
    44One thing to be careful about: if `Infinity` is in the simulation state, JSON representation will show it as "null", which is indistinguishable from other `null` values like `NaN`, that's relevant for the debug serializer (OOS dumps) and possibly the JS debugger? This patch only shows its use in the UI, but I believe the AIs also use this stat.
    55
    6 I agree that an arbitrary integer is no good. So the best solutions IMO are: 1. don't use `Infinity` but make sure all relevant code checks `IsInfinite()` before getting the max amount (maybe it could return undefined?), 2. use `Infinity` and ignore the above issues - that's easiest.
     6I agree that an arbitrary integer is no good. So the best solutions IMO are: 1. don't use `Infinity` but make sure all relevant code checks `IsInfinite()` before getting the max amount (maybe it could return `undefined` to make errors more obvious?), 2. use `Infinity` and ignore the above issues - that's easiest.