Changes between Initial Version and Version 1 of Ticket #1425, comment 5


Ignore:
Timestamp:
Dec 30, 2012, 5:23:00 PM (11 years ago)
Author:
Jonathan Waller

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1425, comment 5

    initial v1  
    1313BattleDetection.prototype.StartTimer doesn't mention that the repeat is optional in the comment.  The fact that you can only use this function when a timer is not active should be mentioned.  Perhaps it would be best to stop the timer when the error message is shown (though of course this should never happen).
    1414
    15 I'm also concerned about efficiency.  Your damage rate algorithm is n^2 with n being the number of attacks in a 5 second period.  With units attacking once per second, in a large battle we could have a lot of attacks happening.  It should be fairly easy to store damage per turn instead.
     15I'm also concerned about efficiency.  Your damage rate algorithm is n^2^ with n being the number of attacks in a 5 second period.  With units attacking once per second, in a large battle we could have a lot of attacks happening.  It should be fairly easy to store damage per turn instead.