Changes between Version 1 and Version 2 of Ticket #1449, comment 19
- Timestamp:
- Jun 18, 2012, 2:09:55 AM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1449, comment 19
v1 v2 36 36 I somewhat object to this naming, as I consider "placement angle" to implicitly mean the final angle that you place models at in the simulation, which in the case of wall segments is shifted -90 degrees CCW from the face normal. What I'm saying is: working with the face normal angle is fine, but you shouldn't document it as being the placement angle; or if you do, explicitly state near the beginning of the file what the conventions are for what you call "placement angles" and "wall angles". 37 37 38 - In `getWallAlignment`, it's generally better to,instead of doing something like this:38 - In `getWallAlignment`, I find that instead of doing something like this: 39 39 {{{ 40 40 if (<expression> === whatever) { … … 43 43 var x = <expression>; 44 44 }}} 45 to do it like this instead:45 it's generally preferable to do it like this instead: 46 46 {{{ 47 47 var x = <expression>;