Changes between Version 1 and Version 2 of Ticket #1449, comment 19


Ignore:
Timestamp:
Jun 18, 2012, 2:09:55 AM (12 years ago)
Author:
vts

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1449, comment 19

    v1 v2  
    3636  I somewhat object to this naming, as I consider "placement angle" to implicitly mean the final angle that you place models at in the simulation, which in the case of wall segments is shifted -90 degrees CCW from the face normal. What I'm saying is: working with the face normal angle is fine, but you shouldn't document it as being the placement angle; or if you do, explicitly state near the beginning of the file what the conventions are for what you call "placement angles" and "wall angles".
    3737
    38   - In `getWallAlignment`, it's generally better to, instead of doing something like this:
     38  - In `getWallAlignment`, I find that instead of doing something like this:
    3939    {{{
    4040if (<expression> === whatever) {
     
    4343var x = <expression>;
    4444}}}
    45     to do it like this instead:
     45    it's generally preferable to do it like this instead:
    4646    {{{
    4747var x = <expression>;