Changes between Version 4 and Version 5 of Ticket #1449, comment 25


Ignore:
Timestamp:
Jun 26, 2012, 12:01:53 PM (12 years ago)
Author:
FeXoR

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1449, comment 25

    v4 v5  
    88No. I wanted to but didn't want to change the function without confirmation. I started a thread for that but none reacted, perhaps I didn't make my point clear enough: http://www.wildfiregames.com/forum/index.php?showtopic=16019. So I added another similar function with support of keyword arguments (don't know if that's a usual practice in javascript) with a reasonable name to support the Iberian civ bonus wall. The old function is still there as it was e.g. still used by RMS Fortress.
    99
    10 I don't really mind the naming. IMO it's not very confusing since placers are called xyzPlacer and are placed with xyzPlacer.place AFAIK so it doesn't begin with "place" anyway.
     10I don't really mind the naming. IMO it's not very confusing since placers are called `xyzPlacer` and are placed with `xyzPlacer.place` AFAIK so it doesn't begin with "place" anyway.
    1111
    1212The new function doesn't take the starting entities but just the civ string and gets the starting entities in the function. I guess that's what you mean?
    1313
    14 I think best would be to use the new function, rename it to the old functions name and add a keyword argument for startingEntities. That way the common case would be easy to use but changed starting entities and the iberian civ bonus walls are supported as well.
     14I think best would be to use the new function, rename it to the old functions name (removing the old one) and add a keyword argument for `startingEntities`. That way the common case would be easy to use but changed starting entities and the Iberian civ bonus walls are supported as well.