Changes between Version 2 and Version 3 of Ticket #1717, comment 11
- Timestamp:
- Nov 20, 2012, 8:51:35 AM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #1717, comment 11
v2 v3 1 1 Replying to [comment:10 leper]: 2 2 3 > (The result of some irc discussion) Add a !GetBatchTimeFactor (or something like that, there is probably a better name for it) to !ProductionQueue that for the moment returns 0.7 and use the function instead of the 0.7 at line 188. In !GuiInterface add this value to ret.production and use that in the GUI. The new !ProductionQueue function could even be extended (though I'd say that this is out of the scope of this ticket, but it wouldn't harm to do it) to read that value from the template and/or be modifiable by technologies (e.g. !ProductionQueue/BatchTime ).3 > (The result of some irc discussion) Add a !GetBatchTimeFactor (or something like that, there is probably a better name for it) to !ProductionQueue that for the moment returns 0.7 and use the function instead of the 0.7 at line 188. In !GuiInterface add this value to ret.production and use that in the GUI. 4 4 5 5 That's a lot like what I tried initially: … … 7 7 https://github.com/zootzoot/0ad/commit/0c281e69d9531751d667e347ef51c074b909999f 8 8 9 My problem is that I don't see a good way to pass the ret.production.batchtimefactorvalue into setupUnitPanel() in gui/session/unit_commands.js. Just slapping on a new batchtimefactor parameter on setupUnitPanel's signature seems nasty.9 My problem is that I don't see a good way to pass the ret.production.batchtimefactor value into setupUnitPanel() in gui/session/unit_commands.js. Just slapping on a new batchtimefactor parameter on setupUnitPanel's signature seems nasty. 10 10 11 11 Should I do that or is there a better way?