Opened 11 years ago
Last modified 5 years ago
#1785 new enhancement
[PATCH] Attack type icons in tooltips
Reported by: | Cerridan | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Backlog |
Component: | UI – In-game | Keywords: | patch, beta |
Cc: | Patch: |
Description (last modified by )
This patch puts attack type icons in tooltips.
It also changes Range: to be the ranged attack icon.
Attachments (2)
Change History (13)
by , 11 years ago
Attachment: | AttackIcons.zip added |
---|
comment:1 by , 11 years ago
Keywords: | patch added; ui removed |
---|
follow-up: 4 comment:2 by , 11 years ago
Description: | modified (diff) |
---|
Thanks for the patch. The code looks good to me. This is basically a design decision. I updated the description to note that this also changes the word Range: to the ranged attack icon.
comment:3 by , 11 years ago
This looks nice. I have two minor complaints: attack icons are after the numbers, whereas resource icons are before the numbers, and it took me a bit to figure out what the icon for "range" meant (as in Range: 16).
The first one you may have already addressed; IIRC, I mentioned it on the forums. If you'd upload the new patch here that would be good.
comment:4 by , 11 years ago
Keywords: | review, patch → review patch |
---|
comment:5 by , 11 years ago
All icons come before the number. Consider this:
You don't say "15: Range", but you do say "Range: 15".
So why should you say "15: [range icon]" instead of "[range icon]: 15" ?
So bottom line, make the icons go before the number it represents, and also make sure that padding is consistent with other icons.
comment:6 by , 11 years ago
Milestone: | Alpha 13 → Alpha 14 |
---|
comment:7 by , 11 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 14 → Backlog |
Thanks for the patch, but I don't really like the trend of adding so many icons to what are already fairly ugly tooltips (and I don't think I'm alone in that assessment), so I'm going to bump this to the backlog. We'll redesign the tooltips, and if we still need these icons in the UI, we'll have the patch to use.
comment:8 by , 10 years ago
Owner: | removed |
---|
comment:9 by , 8 years ago
Keywords: | beta added |
---|
comment:10 by , 6 years ago
Description: | modified (diff) |
---|
I think we really need attack type icons. Stan do you want to do some?
comment:11 by , 5 years ago
Component: | UI & Simulation → In-game UI |
---|
Move tickets to In-game UI
as UI & Simulation
got some sub components.
Icons and patch file.