Changes between Initial Version and Version 1 of Ticket #1963, comment 2


Ignore:
Timestamp:
Jun 5, 2013, 3:47:18 PM (11 years ago)
Author:
Josh

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1963, comment 2

    initial v1  
    1 Something in the GUI seems to be not properly passing a template to [http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js#L1609 GuiInterface.js:1609] which tries to call [http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/helpers/TraderGain.js#L7 TraderGain.js:7] without template data and the function fails at line 28 when it tries to access gain data from the template. A quick and easy fix would be to change line #28 in TraderGain.js to {{{"if(template && template.GainMultiplier)"}}} but that would most likely return an incorrect value to the GUI. The best fix would be to trace the call back into the GUI and fix the undefined template there.
     1Something in the GUI seems to be not properly passing a template to [http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js#L1609 GuiInterface.js:1609] which tries to call [http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/helpers/TraderGain.js#L7 TraderGain.js:7] without template data and the function fails at line 28 when it tries to access gain data from the template. A quick and easy fix would be to change line 28 in TraderGain.js to {{{"if(template && template.GainMultiplier)"}}} but that would most likely return an incorrect value to the GUI. The best fix would be to trace the call back into the GUI and fix the undefined template there.