Changes between Initial Version and Version 1 of Ticket #2241, comment 17


Ignore:
Timestamp:
Dec 31, 2013, 10:54:34 AM (10 years ago)
Author:
wraitii

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2241, comment 17

    initial v1  
    11Tested this morning. C++ side code seems clean, it's readable, it's even clearer in several spots at first sight, I like it, and I haven't noticed any format typo (though I haven't looked at it with extreme scrutiny). It compiles cleanly on my OS.
     2There is a useless line ending change in ComponentManagerSerialization.cpp though.
    23
    34JS side you've missed a commented one l294 of selection_details.j
    45You haven't changed help.txt
    5 You've missed "endgame" in CancelOnErro in functions_utility_errors.js
     6You've missed "endgame" in CancelOnError in functions_utility_errors.js
    67Some search reports no other misses.
    78