Changes between Initial Version and Version 1 of Ticket #2377, comment 7


Ignore:
Timestamp:
Jan 15, 2014, 11:24:39 PM (10 years ago)
Author:
wraitii

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2377, comment 7

    initial v1  
    1 Updated patch for betterness:
    2 -There are now two messages, "MT_TemplateModification" and "MT_ValueModification". In the C++, those are interchangeable (their memory signatures are identical so it's safe to cast both to the same component), in JS I added a call to this.OnValueModification.
    3 -Auras now choose the proper message and template changes send the good message.
    4 -AI still works perfectly (I've also added a caching for unmodified value)
    5 -a few other unrelated changes are in the patch.
     1Updated patch for betterness:\\
     2-There are now two messages, "MT_TemplateModification" and "MT_ValueModification". In the C++, those are interchangeable (their memory signatures are identical so it's safe to cast both to the same component), in JS I added a call to this.OnValueModification.\\
     3-Auras now choose the proper message and template changes send the good message.\\
     4-AI still works perfectly (I've also added a caching for unmodified value)\\
     5-a few other unrelated changes are in the patch.\\
    66
    77Per discussion with sanderd above, I could special case Technology changes, and I do think that we should keep the "One value, One effect" paradigm. Stuff like "Armour/All" are clutter form a programming standpoint. Tools and GUIs should be created instead to affect all values by writing three different effects imo.