Changes between Version 1 and Version 2 of Ticket #2407, comment 6


Ignore:
Timestamp:
Sep 27, 2014, 7:23:27 PM (10 years ago)
Author:
Rolf Sievers

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2407, comment 6

    v1 v2  
    11The attached patch version 1 refactors the unit selection code to be more general. It does not actually address the FR #2407 yet. For that I would like to use infrastructure provided by #2357 which may or may not come in the near future. It does however implement the "I" shortcut which selects idle units of any kind.
    22
     3It changes the way unit highlighting works. Prior, all units where highlighted when arranging the selection, even those that won't be in the final selection. I did consider that a bug and fixed it. Now the highlight uses the exact same filter as the selection itself.
     4
    35Please provide criticism. Should I remove the caching in input.js:482? (For Code readability)