#2831 closed defect (fixed)
[PATCH] Removes Leftover Techs
Reported by: | Nikos | Owned by: | scythetwirler |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 17 |
Component: | UI & Simulation | Keywords: | Technology, patch |
Cc: | badreligionnikoss@… | Patch: |
Description
Athenian Gymnasion and Spartan Syssition had a tech pair that had to be removed, as it was removed from all other factions with alpha 17 changes, probably an oversight.
Attachments (1)
Change History (12)
by , 10 years ago
Attachment: | structures.patch added |
---|
comment:1 by , 10 years ago
Summary: | Removes Leftover Techs → [PATCH] Removes Leftover Techs |
---|
comment:2 by , 10 years ago
Cc: | added |
---|---|
Component: | Build & Packages → UI & Simulation |
comment:3 by , 10 years ago
Keywords: | patch review added |
---|
comment:4 by , 10 years ago
comment:6 by , 10 years ago
Yeah several of them might be reintroduced or edited to something similar, I'd say let them be.
comment:7 by , 10 years ago
line 42 structures.patch
</ProductionQueue>
is indented too much. I think it should have only 2 instead of 6 spaces.
comment:8 by , 10 years ago
niektb/prodigal_son: Fair enough, I see your point. Although they will still exist in the repository history, making them just a svn copy
away.
For reference purposes I've put the list of currently unused techs on pastebin: http://pastebin.com/J4Y76dhR
How about removing the old pair_*
files that point to techs that are still in use but are no longer paired? (See the end of the pastebin link.)
njm: I agree.
comment:9 by , 10 years ago
On the code part, it could be a mistake on my part (you mean it has some unnecessary spaces right?). Those were the first files I ever edited for 0 AD.
If it's so easy to retrieve files, then it wouldn't be a bad idea to remove them, but maybe ask scythe first, he might have plans to use some of them soon. Same with the pairs I guess.
comment:11 by , 8 years ago
Keywords: | review removed |
---|
There are a number of other technologies that aren't researchable from any structures anymore since the rebalance, but still exist in the technologies folder. (I can provide a list.)
Would it be a good idea to include them for removal?