Replying to leper:
Why not just skip the work needed to decide if the nick is not in a word (which might or might not give strange results with some non-latin chars at some point), and just highlight it stupidly? Does not really fix the issue of possibly splitting some chars, but that would be the fault of indexOf returning that as a match.
Which would result in being able to use a simple replace. Short nicks that are common in some words are not really that common.
There's a difference between changing code style because one finds it nicer one way over the other, and deciding a function to knowingly return wrong values that was already written to account for that case.
This issue is reported by players multiple times per year, and those that are affected are pinged very often (acoustically as r18545).
(09:01:09 PM) T: I receive a notification in the chat if it says "t" in a sentence.. Triumvir, elexis
2017-09/2017-09-24-QuakeNet-#0ad-dev.log:13:05 < bb1> so lobby rubbish bbl etc pings me
2017-12/2017-12-14-QuakeNet-#0ad-dev.log:13:00 < bb1> y so I don't get pingen on "lobby"
(It's not only people with 1-3 letters in the nick. Players with 4 letters in the nick and some vowels aren't so rarely affected either that one could neglect that. We also have multiple hannibals online sometimes.)
Which doesn't mean that attachment:t3281_highlighted_playername_almost_without_regex_v1.1.patch
was the cleanest or correct code either.
