Changes between Initial Version and Version 1 of Ticket #3581


Ignore:
Timestamp:
Nov 5, 2015, 12:15:14 PM (9 years ago)
Author:
elexis
Comment:

The problem is that main.cpp calling Frame() in a loop, calling g_Game->Update() as long as the game exists and was started, calling m_TurnManager->Update() every time which always increases the turnnumber by 1.

So the simple solution is to move the m_FinalReplayTurn from ReplayTurnManager to the parent class NetTurnManager, so that the parent class function Update() knows about potentially finite games.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3581

    • Property Keywords patch review added
    • Property Milestone Backlog → Alpha 19
    • Property Summary Visual Replay - simulation continues after end → [PATCH] Visual Replay - simulation continues after end

  • Ticket #3581 – Description

    initial v1  
    44
    55-----
    6 As I can reproduce this issue with r17158, #3309 (r17159) has nothing to do with it.
    7 
    8 The cause of this bug, i.e. the turn manager continuing after the end exists since  #9 / r16727, but it somehow never got apparent.
     6The cause of this bug, i.e. the turn manager continuing after the end exists since  #9 / r16727, but it never got apparent until both #3309 and #3566 were fixed. Presumably the last mock turn with a duration 0 prevented the game from continuing.
    97
    108When I apply this attachment:visual_replay_a18_megapatch.patch:ticket:9 to my a18 and replay that file, the units continue with their current animation but all keep standing on ground, despite the turn manager doing more turns.